fix(build): add empty loader for .node files in esbuild#1120
Open
clichedmoog wants to merge 1 commit intoopennextjs:mainfrom
Open
fix(build): add empty loader for .node files in esbuild#1120clichedmoog wants to merge 1 commit intoopennextjs:mainfrom
clichedmoog wants to merge 1 commit intoopennextjs:mainfrom
Conversation
Prevents esbuild from crashing with "No loader is configured for .node files" when native binary imports are encountered during bundling.
🦋 Changeset detectedLatest commit: 9fcc4fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
requested changes
Mar 29, 2026
Contributor
conico974
left a comment
conico974
left a comment
There was a problem hiding this comment.
Not the right change as previously said in #1117 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a project has native binary dependencies (e.g.
@swc/core, Prisma), esbuild can encounter.nodefiles during bundling and crash with:This was split from #1117 per review feedback.
The root cause is that esbuild resolves package imports (e.g.
@swc/core-darwin-arm64) throughpackage.jsonmain fields, which can point to.nodenative binaries. Since esbuild has no built-in handler for this format, it fails.Changes
Added
loader: { ".node": "empty" }to bothesbuildSyncandesbuildAsyncinhelper.ts, so esbuild produces an empty module instead of crashing.Related issues