Audit-47 : Implement the Security Audit Logging#44
Draft
sudhanshu-raj wants to merge 9 commits into
Draft
Conversation
# Conflicts: # api/src/main/java/org/openmrs/module/auditlogweb/api/AuditService.java # api/src/main/java/org/openmrs/module/auditlogweb/api/dao/AuditDao.java # api/src/main/java/org/openmrs/module/auditlogweb/api/impl/AuditServiceImpl.java
sudhanshu-raj
commented
May 12, 2026
| This check is performed at the end because we first need to know whether | ||
| #changePassword belongs to a password reset or a normal password change, | ||
| so the correct event can be stored in the database. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
Added raw comments for logic understanding , can remove it later.
Contributor
There was a problem hiding this comment.
move this aop stuff under api folder and and rename advice to aop
5 tasks
…ssion to using in-memory set approach
…ion listener pattern
Contributor
Author
|
I removed the custom logout event publisher with with built in user session listener but for login attempt event there is extra event we are capturing which is "ACCOUNT_LOCKED" and that's why we can't use existing listener bcz it not capture this event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Implemented the Security Audit Logging where we are capturing the events like :
Using Application event listeners and AOP for capturing events from the core module. I have added application event publishers on OpenMRS core module side and listeners on audit module for capturing login success/failure, account locked and logout and AOP for password changed, password reset request and password reset . HttpSessionListener for capturing session events. Storing the metadata using per request filter in a separate thread local and session holder for storing and managing the in-application flow events.
And I'm using OpenMRS core 2.7.9-SNAPSHOT for the base, bcz of compatability.
Core PR : openmrs/openmrs-core#6094
Issue I worked on
see https://openmrs.atlassian.net/browse/AUDIT-
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master