RA-2084: Update adminui module to depend on 2.8.x#67
RA-2084: Update adminui module to depend on 2.8.x#67mherman22 wants to merge 5 commits intoopenmrs:masterfrom
Conversation
mherman22
changed the title
mherman22
changed the title
|
@wikumChamith do you mind reviewing this? |
pom.xml
Outdated
| <uiframeworkVersion>4.0.1-SNAPSHOT</uiframeworkVersion> | ||
| <appframeworkVersion>2.19.0-SNAPSHOT</appframeworkVersion> | ||
| <webservicesRestVersion>2.50.0-SNAPSHOT</webservicesRestVersion> | ||
| <legacyuiVersion>1.23.0</legacyuiVersion> |
There was a problem hiding this comment.
I think we could update this to 2.0.0-SNAPSHOT
|
@mherman22, can we bump the project version to 2.0.0-SNAPSHOT and also create 1.x legacy branch. |
| @@ -0,0 +1 @@ | |||
| mock-maker-inline | |||
There was a problem hiding this comment.
So we need mock-maker-inline in order to run the module on java8 since mockito is version 3 where tests fail without it.
But without it on java17 and above, the tests will pass because on java17 we support mockito version 5 where it is not needed.
Take a look at https://github.com/openmrs/openmrs-core/blob/52294dedb8c3fb483d94cc1415dc6f360585cd35/pom.xml#L1176-L1258.
Ref: https://davidvlijmincx.com/posts/writing_higher_quality_tests_with_mockitos_inline_mock_maker/
There was a problem hiding this comment.
What I usually do in cases like this is add the Mockito Inline dependency to the project.
I'm not sure what the best solution is here, so @dkayiwa, it's up to you to decide :)
There was a problem hiding this comment.
I think adding the dependency makes more sense. Since we have usecases of it in the eco anyway.
I will make the change
Done, i have also gone ahead and created a bamboo plan for the 1.x branch of this module, feel free to review that aswell at https://ci.openmrs.org/browse/AU-AU1 |
mherman22
requested review from
wikumChamith
and removed request for
wikumChamith
3 participants
The attempt here is for the adminui to drop the use of providermanagement module for the provider role functionality that is being migrated to openmrs-core.
Fixes https://openmrs.atlassian.net/browse/RA-2084