Skip to content

Update Immunization concepts with more options#8

Merged
denniskigen merged 2 commits intomainfrom
gracepotma-patch-immunizations-july22
Jul 22, 2025
Merged

Update Immunization concepts with more options#8
denniskigen merged 2 commits intomainfrom
gracepotma-patch-immunizations-july22

Conversation

@gracepotma
Copy link
Contributor

Adds the following concepts from CIEL and their cascaded mappings to this sample collection, for more thorough Immunization options in the UI: Added:
168013 Haemophilus influenzae B vaccination
168017 HPV vaccination
168011 MMR vaccination
165616 COVID-19 vaccination
22 - Hepatitis A vaccination
168010 - Influenza vaccination
104531 - Diptheria/pertussis/tetanus combo
160418 DTaP-IPV
75031 - Diphtheria
75030 - Diphtheria adsorbed
104525 - Diphtheria toxoid + anti-Hib
104528 - Diphtheria + Tetanus
104526 - DTaP-HepB-IPV combo
104529 - HibTITER (Diphtheria protein + anti-Hib)
1656 - DTaP
104527 - Diphtheria toxoid / pertussis acellular / tetanus toxoid 84880 - Tetanus toxoid adsorbed
159713 - Meningitis A/C/W-135
159694 - DTAP-Hib-IPV
104805 - Hib-Tetanus toxoid

Adds the following concepts from CIEL and their cascaded mappings to this sample collection, for more thorough Immunization options in the UI:
Added: 
168013  Haemophilus influenzae B vaccination
168017 HPV vaccination
168011 MMR vaccination
165616 COVID-19 vaccination
22 - Hepatitis A vaccination
168010 - Influenza vaccination
104531 - Diptheria/pertussis/tetanus combo
160418 DTaP-IPV
75031 - Diphtheria
75030 - Diphtheria adsorbed
104525 - Diphtheria toxoid + anti-Hib
104528 - Diphtheria + Tetanus
104526 - DTaP-HepB-IPV combo
104529 - HibTITER (Diphtheria protein + anti-Hib)
1656 - DTaP
104527 - Diphtheria toxoid / pertussis acellular / tetanus toxoid
84880 - Tetanus toxoid adsorbed
159713 - Meningitis A/C/W-135
159694 -  DTAP-Hib-IPV
104805 - Hib-Tetanus toxoid
…onContent_v10_autoexpand-10.2025-06-12_203032.zip
@gracepotma gracepotma requested a review from denniskigen July 22, 2025 18:20
@denniskigen
Copy link
Member

Thanks!

@denniskigen denniskigen merged commit b34c24c into main Jul 22, 2025
1 check passed
@samuelmale
Copy link
Member

Thanks @gracepotma for this! However, a concern has been raised related to missing concepts, ie, some of the concepts listed above don't seem to exist in the target environments (dev3). We attributed this to Iniz encountering issues loading the OCL collection or a broken CI/CD pipeline, but on drilling further, we realised that some of the concepts don't exist in the associated OCL collection Eg. "COVID-19 vaccination", "Meningitis A/C/W-135", etc.

@gracepotma any thoughts on this? Did we import the correct collection?

@dkayiwa
Copy link
Member

dkayiwa commented Jul 23, 2025

I have just used to the SDK to setup an new instance of O3. I do not have any iniz errors in the server logs and i am able to find all the listed concepts when i search them by the codes listed on the left hand side (168013, 168017, 168011, etc)

@dkayiwa
Copy link
Member

dkayiwa commented Jul 23, 2025

I have also run it using docker and i can see all the concepts listed above.

@denniskigen
Copy link
Member

denniskigen commented Jul 23, 2025

Might there be a regression somewhere in our CI pipelines, @ibacher? Per @dkayiwa, a dev3 server reset didn’t resolve the issue - these concepts still don’t show up on dev3 in either the concept dictionary or the “Immunization” dropdown in the immunizations form.

@ibacher
Copy link
Member

ibacher commented Jul 23, 2025

So some of these (168013, 168017, 168011, 168010, 165616, etc.) are actually procedure codes and not immunization codes (Hemophilus influenza B is 5261 in CIEL; COVID Immunizations are available by drug name, etc.). However, the real problem is that Docker just decided to skip the build step (from the log):

error	23-Jul-2025 09:26:16	#18 [linux/arm64 dev  5/11] RUN --mount=type=secret,id=m2settings,target=/usr/share/maven/ref/settings-docker.xml if [[ "deploy" != "deploy" || "$(arch)" = "x86_64" ]]; then mvn -s /usr/share/maven/ref/settings-docker.xml -U -P distro deploy; else mvn -s /usr/share/maven/ref/settings-docker.xml -U -P distro install; fi
error	23-Jul-2025 09:26:16	#18 CACHED

So the image that was published didn't have this update, hence why they don't appear in dev3.

@ibacher
Copy link
Member

ibacher commented Jul 23, 2025

I've implemented the same setup we have to prevent such things from happening with the frontend image.

@denniskigen
Copy link
Member

Sorry if I missed something obvious, @ibacher, but what's the resolution here?

@ibacher
Copy link
Member

ibacher commented Jul 25, 2025

Sorry if I missed something obvious, @ibacher, but what's the resolution here?

@denniskigen Basically, I added a CACHE_BUST build argument that should force Docker to rebuild the backend image every time we re-run it regardless of if its been cached or not and then rebuilt the backend. If these still aren't showing up, we'll have to do some more debugging.

@denniskigen
Copy link
Member

Yeah, we need to do some additional debugging. Could you help out with this, @dkayiwa?

@dkayiwa
Copy link
Member

dkayiwa commented Jul 30, 2025

@denniskigen do you mean that it did not work even after the CI builds running again successfully?

@dkayiwa
Copy link
Member

dkayiwa commented Jul 30, 2025

But i can see these concepts on dev3

@denniskigen
Copy link
Member

Is the issue then that these concepts should be associated with the Immunizations convset @gracepotma?

CleanShot 2025-07-30 at 15 20 09@2x

@ibacher
Copy link
Member

ibacher commented Aug 5, 2025

Is the issue then that these concepts should be associated with the Immunizations convset @gracepotma?

Yes. The answers to that concept are how we identify which concepts qualify as Immunizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants