standalone: folly XLOG backend for bundled deps + override knobs#246
Draft
gmarzot wants to merge 1 commit into
Draft
standalone: folly XLOG backend for bundled deps + override knobs#246gmarzot wants to merge 1 commit into
gmarzot wants to merge 1 commit into
Conversation
…st override knobs Add a single MOXYGEN_LOGGING_FOLLY_XLOG option (default ON) that drives each bundled dep's logging shim toward folly XLOG by setting: FIZZ_LOGGING_FOLLY_LOGGING=ON (facebookincubator/fizz#168, landed) WANGLE_LOGGING_FOLLY_LOGGING=ON (facebook/wangle#252, open) MVFST_LOGGING_BACKEND=XLOG (facebook/mvfst#456, open) Each cache var is a forward-compatible no-op on the current pin and activates when the corresponding upstream shim lands and the rev pin advances past it. Also add WANGLE_REPO_OVERRIDE / WANGLE_REV_OVERRIDE and MVFST_REPO_OVERRIDE / MVFST_REV_OVERRIDE knobs mirroring the existing fizz/proxygen pattern so we can build against not-yet-merged upstream branches for previewing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MOXYGEN_LOGGING_FOLLY_XLOGoption (default ON) that drives each bundled dep's logging shim toward folly XLOG by setting:FIZZ_LOGGING_FOLLY_LOGGING=ON(fizz: pluggable logging backend (glog / folly xlog / disabled) facebookincubator/fizz#168, landed)WANGLE_LOGGING_FOLLY_LOGGING=ON(Add configurable logging shim (#252) facebook/wangle#252, open)MVFST_LOGGING_BACKEND=XLOG(mvfst: configurable logging backend (glog / xlog / disabled) facebook/mvfst#456, open)WANGLE_REPO_OVERRIDE/WANGLE_REV_OVERRIDEandMVFST_REPO_OVERRIDE/MVFST_REV_OVERRIDEknobs mirroring the existing fizz/proxygen pattern so we can build against not-yet-merged upstream branches for previewing.Openmoq fork only —
standalone/is our addition.Test plan
.ashould be built in xlog mode.-DFIZZ_REV_OVERRIDE=<post-#168 SHA>activates the xlog backend today.This change is