[draft]qlog: Implement MoQQLogFactory to enhance logging for QUIC connections#242
Open
akash-a-n wants to merge 1 commit into
Open
[draft]qlog: Implement MoQQLogFactory to enhance logging for QUIC connections#242akash-a-n wants to merge 1 commit into
akash-a-n wants to merge 1 commit into
Conversation
akash-a-n
requested review from
Oxyd,
TimEvens,
afrind,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
akash-a-n
commented
May 30, 2026
Author
akash-a-n
left a comment
akash-a-n
left a comment
There was a problem hiding this comment.
@afrind
I wanted to get you thoughts on this integration pattern that wraps the TransportFactory.
Since we use HQServer for WebTransport connections, I am unable to set an asynchronous logger for qlogs because proxygen's HQServerTransportFactory's make function hardcodes streaming to false.
Ideally having a factory in proxygen makes more sense as its the owner, but I don't know if they can be persuaded in time for the change.
Let me know if this method is fine or if you have any other ideas?
@akash-a-n made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on afrind, gmarzot, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is