relay: make stop() idempotent and keep context_ alive during teardown#372
Merged
Conversation
Guard stop() with a stopped_ flag instead of context_ presence, and stop resetting context_. terminateClientSession can run after stop() returns, from handleClientSession coroutines still draining on the evb/IO threads, so context_ must outlive stop(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
afrind
requested review from
Oxyd,
TimEvens,
akash-a-n,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
gmarzot
approved these changes
Jun 1, 2026
Contributor
gmarzot
left a comment
gmarzot
left a comment
There was a problem hiding this comment.
@gmarzot reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on akash-a-n, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard stop() with a stopped_ flag instead of context_ presence, and stop resetting context_. terminateClientSession can run after stop() returns, from handleClientSession coroutines still draining on the evb/IO threads, so context_ must outlive stop().
Calling stop with active sessions could lead to a null ptr deref on context_.
This change is