Draft
Conversation
- Build Tracy client as a shared library for multi-DLL support. - Add profiling zones to major engine subsystems. - Adjust frame markers for accurate frame time capture. - Drain the backlog upon graceful exit.
Member
|
I think the maximum would be to just integrate it in the build in the least invasive way possible without touching any C/C++ source file (except for initializing or cleaning up). godotengine/godot#104851 Someone integrated Tracy to Godot Engine, but in a way that makes it soft-dependent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is now good enough to discuss how (and if) it should be merged, I think.
Tracy is a pretty great frame profiler: https://wolf.nereid.pl/projects/tracy-profiler/
Instructions for use:
TRACY_ENABLE=ONin your CMake cache and build,I see two major points of contention:
#defineempty macros that boil all instrumentation away), regardless of whetherTRACY_ENABLEis on/true or not, is the desired one.There's also the question of whether
sys_tracy.cpplives in the right place of the source tree vs which target it's part of (tracy), missing documentation, code style etc.I'm also considering upstreaming it into ioquake3, but that's a bunch of additional work.