Refactor: Split Check status (impl and test), Remove CodeRef, CodeRefs #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wysiwys
approved these changes
Oct 15, 2025
Collaborator
wysiwys
left a comment
wysiwys
left a comment
There was a problem hiding this comment.
This looks good, I think! As a follow-up, it would be good to check the code search links and see if there are any other places in the codebase that need to be annotated with references to validation checks, so they appear in the search. But overall, these changes looks good to merge.
Collaborator
Author
|
You're right! Opened follow-up: #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the status of a check more explicit by having separate fields for stating whether a check is implemented and whether it is tested. It also removes the CodeRefs, because we replaced them in favor of searching the code for the identifiers.