Skip to content

Conversation

@EmanAbdelhaleem
Copy link
Contributor

@EmanAbdelhaleem EmanAbdelhaleem commented Jan 7, 2026

Fixes #1593
Depends on #1576
Related to #1575

Details

This PR implements EvaluationMeasures resource, and refactor its existing functions

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 41.10092% with 321 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.54%. Comparing base (99928f8) to head (6236112).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
openml/_api/clients/http.py 24.59% 141 Missing ⚠️
openml/_api/resources/base/versions.py 24.13% 66 Missing ⚠️
openml/_api/resources/tasks.py 21.27% 37 Missing ⚠️
openml/_api/resources/base/fallback.py 24.32% 28 Missing ⚠️
openml/testing.py 48.71% 20 Missing ⚠️
openml/_api/resources/evaluation_measures.py 31.81% 15 Missing ⚠️
openml/_api/runtime/core.py 80.00% 6 Missing ⚠️
openml/_api/resources/base/base.py 86.20% 4 Missing ⚠️
openml/_api/resources/datasets.py 77.77% 2 Missing ⚠️
openml/_api/__init__.py 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
- Coverage   52.75%   51.54%   -1.22%     
==========================================
  Files          36       50      +14     
  Lines        4333     4870     +537     
==========================================
+ Hits         2286     2510     +224     
- Misses       2047     2360     +313     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@geetu040 geetu040 mentioned this pull request Jan 7, 2026
25 tasks
Copy link
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:

Fixes #1593
Depends on #1576
Related to #1575

@EmanAbdelhaleem EmanAbdelhaleem force-pushed the evaluation-measures-mig branch from f0c57de to e091d57 Compare January 28, 2026 03:28
@EmanAbdelhaleem EmanAbdelhaleem force-pushed the evaluation-measures-mig branch from 4749d3c to 1ae3fb6 Compare January 29, 2026 10:57
Copy link
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk code look good so far, please take a look at #1575 (comment) and make changes accordingly where needed, though I doubt any point affects this PR, but please check.
all tests (existing and new) should pass to make sure we are retaining the original functionality of the sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] V1 → V2 API Migration - evaluation measures

4 participants