-
-
Notifications
You must be signed in to change notification settings - Fork 213
Default to not checking for duplicates #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes it so by default people can use this feature without authenticating with OpenML.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1431 +/- ##
===========================================
- Coverage 52.75% 52.69% -0.06%
===========================================
Files 36 36
Lines 4343 4346 +3
===========================================
- Hits 2291 2290 -1
- Misses 2052 2056 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| with tmp_file.open("w") as config_file: | ||
| config_file.write(config_file_content) | ||
| read_config = openml.config._parse_config(tmp_path) | ||
| read_config = openml.config._parse_config(tmp_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was passed a directory... which lead to a silent error and an empty config, which went unnoticed because the values below happened to coincide with the old defaults :D
LennartPurucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Metadata
avoid_duplicate_runsparameter ofopenml.runs.run_model_on_taskandopenml.runs.run_flow_on_tasknow defaults toFalseinstead ofTrueand this default is now configurable from your configuration file.Details
The main reason for doing this is so that it doesn't require an API key by default. This API key was necessary to check for duplicate runs, because that uses an authenticated flow endpoint (
flow/exists).