Skip to content

Conversation

@PGijsbers
Copy link
Collaborator

@PGijsbers PGijsbers commented Jun 20, 2025

Metadata

  • Reference Issue: run_model_on_task: make avoid_duplicate_runs=False the default #1143
  • New Tests Added: No
  • Documentation Updated: Documentation is being rewritten in other PRs, will check back later.
  • Change Log Entry: The avoid_duplicate_runs parameter of openml.runs.run_model_on_task and openml.runs.run_flow_on_task now defaults to False instead of True and this default is now configurable from your configuration file.

Details

The main reason for doing this is so that it doesn't require an API key by default. This API key was necessary to check for duplicate runs, because that uses an authenticated flow endpoint (flow/exists).

This makes it so by default people can use this feature without
authenticating with OpenML.
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.69%. Comparing base (a098193) to head (377d31c).

Files with missing lines Patch % Lines
openml/runs/functions.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1431      +/-   ##
===========================================
- Coverage    52.75%   52.69%   -0.06%     
===========================================
  Files           36       36              
  Lines         4343     4346       +3     
===========================================
- Hits          2291     2290       -1     
- Misses        2052     2056       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PGijsbers PGijsbers changed the title Default to not checking for duplicates [wip]Default to not checking for duplicates Jun 20, 2025
with tmp_file.open("w") as config_file:
config_file.write(config_file_content)
read_config = openml.config._parse_config(tmp_path)
read_config = openml.config._parse_config(tmp_file)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was passed a directory... which lead to a silent error and an empty config, which went unnoticed because the values below happened to coincide with the old defaults :D

@PGijsbers PGijsbers changed the title [wip]Default to not checking for duplicates Default to not checking for duplicates Jun 20, 2025
Copy link
Contributor

@LennartPurucker LennartPurucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LennartPurucker LennartPurucker merged commit 0909980 into develop Jun 20, 2025
13 checks passed
@LennartPurucker LennartPurucker deleted the dont-check-for-duplicate branch June 20, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants