Fix Windows CI (convert to pytest) #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1430 +/- ##
===========================================
- Coverage 52.75% 52.69% -0.06%
===========================================
Files 36 36
Lines 4343 4346 +3
===========================================
- Hits 2291 2290 -1
- Misses 2052 2056 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PGijsbers
force-pushed
the
fix/windows-ci
branch
from
5c97bb9 to
78111f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the tests to pytest apparently also seemed to work fine on account that it uses different setup/teardown mechanism (and since the tests didn't fail, it was the cleanup that failed).