Skip to content

Conversation

@PGijsbers
Copy link
Collaborator

Metadata

Details

The scikit-learn extension repository is here: https://github.com/openml/openml-sklearn
It is now used as a dependency for tests only, which means that scikit-learn will no longer be a dependency of openml-python itself.
Next steps are to remove dependency on the scikit-learn extension as much as possible for tests.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.75%. Comparing base (6103874) to head (0a34613).

Files with missing lines Patch % Lines
openml/extensions/functions.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1424      +/-   ##
===========================================
- Coverage    53.71%   52.75%   -0.97%     
===========================================
  Files           38       36       -2     
  Lines         5229     4343     -886     
===========================================
- Hits          2809     2291     -518     
+ Misses        2420     2052     -368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@LennartPurucker LennartPurucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small question

@PGijsbers PGijsbers merged commit 3b04654 into develop Jun 19, 2025
13 checks passed
@PGijsbers PGijsbers deleted the omg-its-finally-happening branch June 19, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants