Skip to content

FIX CI Final Final Final Final #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 2 commits into from
Jun 19, 2025
Merged

FIX CI Final Final Final Final #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
675b0f6
fix: test that might have a race condition now
LennartPurucker Jun 18, 2025
48a48c9
maint: make sure workflow does not fail if there is nothing to push.
LennartPurucker Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,10 @@ jobs:
git config --global user.name 'Github Actions'
git config --global user.email 'not@mail.com'
git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}
git commit -am "$last_commit"
git diff --quiet @{u} HEAD || git push
# Only commit and push if there are changes
if ! git diff --cached --quiet; then
git commit -m "$last_commit"
git push
else
echo "Branch is up to date with origin/gh-pages, no need to update docs. Skipping."
fi
7 changes: 5 additions & 2 deletions tests/test_openml/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def test_non_writable_home(self, log_handler_mock, warnings_mock):
assert not log_handler_mock.call_args_list[0][1]["create_file_handler"]
assert openml.config._root_cache_directory == Path(td) / "something-else"

@unittest.skipIf(platform.system() != "Linux","XDG only exists for Linux systems.")
@unittest.skipIf(platform.system() != "Linux", "XDG only exists for Linux systems.")
def test_XDG_directories_do_not_exist(self):
with tempfile.TemporaryDirectory(dir=self.workdir) as td:
# Save previous state
Expand Down Expand Up @@ -131,8 +131,11 @@ def test_switch_from_example_configuration(self):
assert openml.config.server == self.production_server

def test_example_configuration_stop_before_start(self):
"""Verifies an error is raised is `stop_...` is called before `start_...`."""
"""Verifies an error is raised if `stop_...` is called before `start_...`."""
error_regex = ".*stop_use_example_configuration.*start_use_example_configuration.*first"
# Tests do not reset the state of this class. Thus, we ensure it is in
# the original state before the test.
openml.config.ConfigurationForExamples._start_last_called = False
self.assertRaisesRegex(
RuntimeError,
error_regex,
Expand Down
Loading