Remove from_config and only keep from_configs#659
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
=========================================
Coverage ? 70.05%
=========================================
Files ? 55
Lines ? 6773
Branches ? 0
=========================================
Hits ? 4745
Misses ? 2028
Partials ? 0 ☔ View full report in Codecov by Sentry. |
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Few actual changes, mostly sanity check and also wondering if you used runscores in any way.
| def from_config(config: Namespace): | ||
| global __INSTANCE__ | ||
| transform_config(config, _backward_compatibility_config_rules_) | ||
| __INSTANCE__ = Resources(config) | ||
| return __INSTANCE__ |
There was a problem hiding this comment.
Actual change, the replacing function is directly below (unchanged).
| @pytest.fixture | ||
| def oml_config(): | ||
| return from_config( | ||
| return from_configs( |
|
@eddiebergman I was doing the "round-robin" reviewer assignment, but it seemed like Nick might be on vacation. So to keep things moving I'm assigning you instead. Hope that's alright with you. |
|
Looks good to me, thanks for highlighting the actual changes. Not familiar with this functionality really, but makes sense from a high-level overview. One recommendation is to have a blanket ruff formatting PR to make future changes easier to review :) |
|
Thanks for checking! |
3 participants
Working towards a moving target at #658, I am splitting off individual cleaned up commits for easier reviews.
This PR removes the
from_configfunction since it is interchangable with the more flexiblefrom_configs.I could detect no use for the
runscoresscript, and it didn't even work, so I took the liberty to also remove that.