Skip to content

Handle multi-particle importance syntax#56

Merged
paulromano merged 2 commits intomainfrom
multi-importance
Oct 24, 2025
Merged

Handle multi-particle importance syntax#56
paulromano merged 2 commits intomainfrom
multi-importance

Conversation

@paulromano
Copy link
Contributor

As described in #55, when a cell importance lists multiple particles, right now it crashes the converter. This is permitted as described in the MCNP manual (emphasis added):

Any particle symbol from Table 4.3. May also be a list of particle symbols separated by commas as long as the importance are the same for the desired importance are the same for the different listed particle types.

This PR adds support for this syntax along with corresponding tests.

Closes #55

@paulromano paulromano enabled auto-merge (squash) October 24, 2025 22:26
@paulromano paulromano merged commit 498d46c into main Oct 24, 2025
1 check passed
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.86%. Comparing base (f0145bf) to head (3f8a043).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files           3        3           
  Lines         731      731           
  Branches      191      191           
=======================================
  Hits          635      635           
  Misses         52       52           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulromano paulromano deleted the multi-importance branch October 24, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graveyard definition bug

1 participant