Open
Conversation
Contributor
Author
|
Just rewrote the function to explicitly make sure the built rotation matrix is also right handed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While converting some benchmarks we were finding some issues with quadric surface rotations. Apparently, in the case of 45 degrees rotation and degenerate eigenvalues of the coefficient matrix numpy does not know how to unambiguously order the eigenvectors in the rotation matrix. @davidepettinari and I think we have found a solution to this and we added a function able to reorder the rotation matrix according to two criteria. First the eigenvectors are ordered so their element with the highest absolute value stand on the diagonal. Then, if there is still ambiguity, it orders the ambiguous eigenvectors left in order to achieve orthogonality.
We went from this (not meshable):
To this (meshable):