Skip to content

Refactor Ray class into its own file#3845

Merged
paulromano merged 7 commits intoopenmc-dev:developfrom
GuySten:ray
Mar 6, 2026
Merged

Refactor Ray class into its own file#3845
paulromano merged 7 commits intoopenmc-dev:developfrom
GuySten:ray

Conversation

@GuySten
Copy link
Contributor

@GuySten GuySten commented Mar 2, 2026

Description

Currently, the cpp Ray class is located at plot.cpp.
I intend to use this class for the point detector feature.
This PR move this class into ray.cpp because this class is useful for general ray tracing and not solely for plotting.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten requested a review from paulromano March 2, 2026 23:05
@GuySten GuySten marked this pull request as ready for review March 2, 2026 23:23
@GuySten GuySten requested a review from pshriwise as a code owner March 2, 2026 23:23
@vitmog
Copy link
Contributor

vitmog commented Mar 3, 2026

@GuySten Extracting Ray is useful, in my opinion. Do you see an overlap of your plans with #3833?

@GuySten
Copy link
Contributor Author

GuySten commented Mar 3, 2026

Yes, I intend to create a subclass of Ray with the functionality in that issue for point detector purpose.

@paulromano paulromano enabled auto-merge (squash) March 6, 2026 00:16
@paulromano paulromano merged commit be4148a into openmc-dev:develop Mar 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants