Use clang-format version 18 for CI format checks#3840
Merged
GuySten merged 2 commits intoopenmc-dev:developfrom Feb 27, 2026
Merged
Use clang-format version 18 for CI format checks#3840GuySten merged 2 commits intoopenmc-dev:developfrom
GuySten merged 2 commits intoopenmc-dev:developfrom
Conversation
GuySten
added
Test Suite
Merging Soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the version of clang-format used in our format check CI job to version 18, whereas it is currently using version 15. This was discussed in #2746 and #3829. Version 18 is the default in Ubuntu 24.04 but I'm open to other opinions on what we should be using. After playing around with multiple versions (18, 19, 20), they all give slightly different formatting results so it seems like there is no good way to avoid some churn, but at least with a more recent version it should be easier for people to install if needed.
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)