Adding regularmesh tally plot#2629
Closed
shimwell wants to merge 18 commits intoopenmc-dev:developfrom
Closed
Conversation
shimwell
commented
Aug 4, 2023
shimwell
commented
Aug 4, 2023
paulromano
reviewed
Sep 1, 2023
Contributor
paulromano
left a comment
There was a problem hiding this comment.
I'm not sure how I feel about this one. When it comes to producing plots, my general thought is that for users who want to produce something easily, we should enable that through GUI applications like openmc-plotter and openmc-plot. Power users will likely want more customization over their plots, so the effort for them to figure out a function like this may not be worth it.
Member
Author
|
Thanks for considering this PR @paulromano . Looks like it is not necessary to add this code to the openmc repository. I still have a need for this type of functionality so I have created a small python package just in case it is useful for anyone else. |
Contributor
|
Thanks for understanding @shimwell. I just gave you a ⭐ on your mini package 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Plotting mesh tallies along with the outline geometry in one function call.
This would be very helpful as a mesh tally plot is a very common output for posters, presentations papers.
The function allows lots of options for scaling, log plots, colorbars with args and lots of customizable options for imshow and contour via kwarg
testing of the plot includes some axis attribute checks and checking function runs but I've also been writting scripts to test the geometry like the one below
Checklist
- [ ] I have run clang-format on any C++ source files (if applicable)Example script to show this function in use
I have another example script that makes the FLF logo over here if you want to see more test scripts