K eff search with tally derivatives#31
Open
pranavkantgaur wants to merge 15 commits intoopenmc-dev:developfrom
Open
K eff search with tally derivatives#31pranavkantgaur wants to merge 15 commits intoopenmc-dev:developfrom
pranavkantgaur wants to merge 15 commits intoopenmc-dev:developfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Draft
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a demonstration of using tally derivatives of nuclide concentrations for gradient based k-eff search. It is authored entirely using Copilot and reviewed by me. The performance is compared with the python API . The problem statement is borrowed from the criticality search notebook but extended to parameterize the target k_eff.
Also, I will be interested in knowing if extending the python API (search_for_keff function) to support the gradient based search option built-in makes sense. I can work on a PR for that.