Skip to content

fix: add FILES_BLOB_DIR to docker-compose and guard undefined array access in console #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Littly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add FILES_BLOB_DIR to docker-compose and guard undefined array access in console #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/console/src/pages/AgentsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,21 @@ export function AgentsList() {
setAuxLoading(true);
try {
const all = await api<{ data: Agent[] }>("/v1/agents?limit=200&status=any");
setAllAgents(all.data);
setAllAgents(all.data ?? []);
await Promise.allSettled([
(async () => {
const sk = await api<{
data: Array<{ id: string; name: string; description: string }>;
}>("/v1/skills");
setCustomSkills(sk.data);
setCustomSkills(sk.data ?? []);
})().catch((e) => console.warn("[AgentsList] /v1/skills aux fetch failed", e)),
(async () => {
const mc = await api<{ data: ModelCard[] }>("/v1/model_cards?limit=200");
setModelCards(mc.data);
setModelCards(mc.data ?? []);
})().catch((e) => console.warn("[AgentsList] /v1/model_cards aux fetch failed", e)),
(async () => {
const rt = await api<{ runtimes: Runtime[] }>("/v1/runtimes");
setRuntimes(rt.runtimes);
setRuntimes(rt.runtimes ?? []);
})().catch((e) => console.warn("[AgentsList] /v1/runtimes aux fetch failed", e)),
]);
} finally {
Expand Down
4 changes: 2 additions & 2 deletions apps/console/src/pages/RuntimesList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,11 @@ export function RuntimesList() {
},
{
id: "agents",
accessorFn: (r) => r.agents.map((a) => a.id).join(", "),
accessorFn: (r) => (r.agents ?? []).map((a) => a.id).join(", "),
header: "Agents detected",
cell: ({ row }) => (
<span className="font-mono text-xs text-fg-muted">
{row.original.agents.length === 0 ? "—" : row.original.agents.map((a) => a.id).join(", ")}
{(row.original.agents ?? []).length === 0 ? "—" : (row.original.agents ?? []).map((a) => a.id).join(", ")}
</span>
),
},
Expand Down
2 changes: 1 addition & 1 deletion apps/console/src/pages/agents/AgentFormDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ function BasicTab({
{runtimes.map((r) => (
<SelectOption key={r.id} value={r.id} disabled={r.status !== "online"}>
{r.hostname} ({r.status}
{r.status === "online" && r.agents.length
{r.status === "online" && r.agents?.length
? ` · ${r.agents.length} agents`
: ""}
)
Expand Down
3 changes: 3 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ services:
# agent uses to deliver downloadable artefacts. Bind-mounted into
# ./data so files survive `docker stop`.
SESSION_OUTPUTS_DIR: /app/data/session-outputs
# Local FS blob store for uploaded files. When FILES_S3_ENDPOINT is
# set the S3 backend is used instead and this var is ignored.
FILES_BLOB_DIR: /app/data/files-blobs
# Outbound credential injection via the oma-vault sidecar. When set,
# LocalSubprocessSandbox.setOutboundContext wires the subprocess env
# to route HTTPS traffic through oma-vault for header injection.
Expand Down