Skip to content

Conversation

@jmtd
Copy link
Contributor

@jmtd jmtd commented Nov 27, 2025

This test failure is polluting GHA logs for unrelated changes (e.g. #721 (comment))


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372660 needs maintainer approval

Issue

  • JDK-8372660: [8u] ProblemList TestCPUAwareness until 8370492 is addressed (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/727/head:pull/727
$ git checkout pull/727

Update a local copy of the PR:
$ git checkout pull/727
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/727/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 727

View PR using the GUI difftool:
$ git pr show -t 727

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/727.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8372660: [8u] ProblemList TestCPUAwareness until 8370492 is addressed

Reviewed-by: andrew, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2025

Webrevs

@zzambers zzambers mentioned this pull request Dec 2, 2025
6 tasks
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for sorting this one.

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

⚠️ @jmtd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jmtd
Copy link
Contributor Author

jmtd commented Dec 7, 2025

/approval request clean up GitHub Actions test results until we can properly resolve this issue in 8u

@openjdk
Copy link

openjdk bot commented Dec 7, 2025

@jmtd
8372660: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 7, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Dec 10, 2025

/approve yes

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@jerboaa
8372660: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 10, 2025
@jmtd
Copy link
Contributor Author

jmtd commented Dec 11, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

Going to push as commit e00c683.
Since your change was applied there have been 6 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2025
@openjdk openjdk bot closed this Dec 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@jmtd Pushed as commit e00c683.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jmtd jmtd deleted the 8372660-8u branch December 11, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants