Skip to content

Conversation

@DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Dec 8, 2025

Hi all,

This pull request contains a backport of commit ad1033d6 from the openjdk/jdk repository.

The commit being backported was authored by Dingli Zhang on 23 Jun 2025 and was reviewed by Fei Yang, Feilong Jiang, SendaoYan and Doug Simon.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8360169 needs maintainer approval

Issue

  • JDK-8360169: Problem list CodeInvalidationReasonTest.java on linux-riscv64 until JDK-8360168 is fixed (Sub-task - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/68/head:pull/68
$ git checkout pull/68

Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/68/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 68

View PR using the GUI difftool:
$ git pr show -t 68

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/68.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ad1033d68f4dd030cad27f9868d4fa83b5080bcd 8360169: Problem list CodeInvalidationReasonTest.java on linux-riscv64 until JDK-8360168 is fixed Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

⚠️ @DingliZhang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2025
@DingliZhang
Copy link
Member Author

/approval request JDK-8359064 has been backported to jdk25u. Need to backport this followup fix to void test noise on riscv64.

@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@DingliZhang
8360169: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 8, 2025
@DingliZhang DingliZhang marked this pull request as draft December 8, 2025 03:23
@openjdk openjdk bot removed rfr Pull request is ready for review approval Requires approval; will be removed when approval is received labels Dec 8, 2025
@RealFYang
Copy link
Member

RealFYang commented Dec 8, 2025

Just remind: we need to wait for merge of fix for JDK-8359064 into this repo before this backport.

@DingliZhang DingliZhang marked this pull request as ready for review December 17, 2025 12:45
@DingliZhang
Copy link
Member Author

/approval request JDK-8359064 has been backported to jdk25u. Need to backport this followup fix to void test noise on riscv64.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@DingliZhang
8360169: The approval request was already up to date.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 17, 2025
@DingliZhang
Copy link
Member Author

Just remind: we need to wait for merge of fix for JDK-8359064 into this repo before this backport.

I see fix for JDK-8359064 is in this repo now so I reopened this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants