8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin

[rm-gh-8]

Backporting JDK-8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin.

For parity with Oracle JDK.

Fixed intermittent test failure caused by sampling two floats that occasionally produce identical values. Now retries sampling until distinct values are obtained. Also improved error reporting by throwing exceptions during generator construction instead of at sampling time.

Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed), and related compiler tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Passed) - make test-tier1
(Passed) - make test TEST=test/hotspot/jtreg/compiler

Results are attached.

linux-aarch64-jtreg-tier1.log
linux-x64-jtreg-tier1.log
macos-aarch64-jtreg-tier1.log
windows-x64-jtreg-tier1.log

linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

---

Progress

• Change must not contain extraneous whitespace
• JDK-8369804 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/67/head:pull/67
$ git checkout pull/67

Update a local copy of the PR:
$ git checkout pull/67
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/67/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 67

View PR using the GUI difftool:
$ git pr show -t 67

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/67.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 53e7ea8: 8370325: G1: Disallow GC for TLAB allocation
• 9d12072: 8358686: CDS and AOT can cause buffer truncation warning even when logging is disabled
• f31097e: 8357591: Re-enable CDS test cases for jvmci after JDK-8345826
• ... and 57 more: https://git.openjdk.org/jdk25u-dev/compare/796f2b42b07c150602acc98fe1a9ad69c5bc5d0d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (7acaa2a2)

[rm-gh-8]

/approval request for backport of JDK-8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin.

For parity with Oracle JDK.

[openjdk]

@rm-gh-8
8369804: The approval request has been created successfully.

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version 7acaa2a) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 559f805.
Since your change was applied there have been 60 commits pushed to the master branch:

• 53e7ea8: 8370325: G1: Disallow GC for TLAB allocation
• 9d12072: 8358686: CDS and AOT can cause buffer truncation warning even when logging is disabled
• f31097e: 8357591: Re-enable CDS test cases for jvmci after JDK-8345826
• ... and 57 more: https://git.openjdk.org/jdk25u-dev/compare/796f2b42b07c150602acc98fe1a9ad69c5bc5d0d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rm-gh-8 Pushed as commit 559f805.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.