-
Notifications
You must be signed in to change notification settings - Fork 26
8371864: GaloisCounterMode.implGCMCrypt0 AVX512/AVX2 intrinsics stubs cause AES-GCM encryption failure for certain payload sizes #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
Tests are all passing. I am putting the stick in the ground here, and will request approval next week, seeing if we have any bugtail from the fix in mainline. |
|
/approval request Fixes another AES/GCM regression in JDK 25. Patch applies cleanly. New regression test fails without the fix, and passes with it. All other tests pass. Tested on both AVX2 and AVX-512 machines. Risk/benefit is medium-low: patch is new but simple, failure caught in prod, caught by stress test, recent regression. |
|
Push approval granted. /integrate |
|
Going to push as commit 4b7defb.
Your commit was automatically rebased without conflicts. |
Fixes another JDK 25 regression in AES/GCM on x86_64.
Additional testing:
jdk_securityjdk_securityallProgress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/54/head:pull/54$ git checkout pull/54Update a local copy of the PR:
$ git checkout pull/54$ git pull https://git.openjdk.org/jdk25u-dev.git pull/54/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 54View PR using the GUI difftool:
$ git pr show -t 54Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/54.diff
Using Webrev
Link to Webrev Comment