Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Dec 3, 2025

Fixes another JDK 25 regression in AES/GCM on x86_64.

Additional testing:

  • Linux x86_64 server fastdebug, AVX2 machine, new regression test fails without the patch, passes with it
  • Linux x86_64 server fastdebug, AVX2 machine, jdk_security
  • Linux x86_64 server fastdebug, AVX-512 machine, new regression test fails without the patch, passes with it
  • Linux x86_64 server fastdebug, AVX-512 machine, jdk_security
  • Linux x86_64 server fastdebug, AVX-512 machine, all

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371864 needs maintainer approval

Issue

  • JDK-8371864: GaloisCounterMode.implGCMCrypt0 AVX512/AVX2 intrinsics stubs cause AES-GCM encryption failure for certain payload sizes (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/54.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371864: GaloisCounterMode.implGCMCrypt0 AVX512/AVX2 intrinsics stubs cause AES-GCM encryption failure for certain payload sizes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6cb1c8f9cfcb797af788ca8fb490f388cc68f525 8371864: GaloisCounterMode.implGCMCrypt0 AVX512/AVX2 intrinsics stubs cause AES-GCM encryption failure for certain payload sizes Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2025

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Dec 3, 2025

Tests are all passing. I am putting the stick in the ground here, and will request approval next week, seeing if we have any bugtail from the fix in mainline.

@shipilev
Copy link
Member Author

shipilev commented Dec 8, 2025

/approval request Fixes another AES/GCM regression in JDK 25. Patch applies cleanly. New regression test fails without the fix, and passes with it. All other tests pass. Tested on both AVX2 and AVX-512 machines. Risk/benefit is medium-low: patch is new but simple, failure caught in prod, caught by stress test, recent regression.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@shipilev
8371864: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 8, 2025
@shipilev
Copy link
Member Author

Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

Going to push as commit 4b7defb.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 10, 2025
@openjdk openjdk bot closed this Dec 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@shipilev Pushed as commit 4b7defb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant