-
Notifications
You must be signed in to change notification settings - Fork 26
8366817: test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java and JdkProcClient.java should not delete logs #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 80 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/approval request Clean backport to make test more robustness. Change has been verified locally on linux-x64 by run the test entry test/jdk/javax/net/ssl/compatibility/BasicConnectTest.java. Backport parity with 25.0.3-oracle, test-fix only, no risk. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
@sendaoYan |
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed clean.
|
/approve yes |
|
@gnu-andrew |
|
Thanks for the review and approve. /integrate |
|
Going to push as commit b65e0bb.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit b65e0bb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit c0c76703 from the openjdk/jdk repository.
The commit being backported was authored by Fernando Guallini on 4 Nov 2025 and was reviewed by SendaoYan and Rajan Halade.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/50/head:pull/50$ git checkout pull/50Update a local copy of the PR:
$ git checkout pull/50$ git pull https://git.openjdk.org/jdk25u-dev.git pull/50/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 50View PR using the GUI difftool:
$ git pr show -t 50Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/50.diff
Using Webrev
Link to Webrev Comment