Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 3, 2025

Hi all,

This pull request contains a backport of commit c0c76703 from the openjdk/jdk repository.

The commit being backported was authored by Fernando Guallini on 4 Nov 2025 and was reviewed by SendaoYan and Rajan Halade.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366817 needs maintainer approval

Issue

  • JDK-8366817: test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java and JdkProcClient.java should not delete logs (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/50.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366817: test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java and JdkProcClient.java should not delete logs

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make test more robustness. Change has been verified locally on linux-x64 by run the test entry test/jdk/javax/net/ssl/compatibility/BasicConnectTest.java. Backport parity with 25.0.3-oracle, test-fix only, no risk.

@openjdk openjdk bot changed the title Backport c0c76703bc10d5caa1cda7e2820d0702df5b8008 8366817: test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java and JdkProcClient.java should not delete logs Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Dec 3, 2025
@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@sendaoYan
8366817: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Dec 3, 2025

Webrevs

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Dec 3, 2025
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Dec 20, 2025

@gnu-andrew
8366817: There is no maintainer approval request for this issue.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2025
@sendaoYan
Copy link
Member Author

Thanks for the review and approve.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2025

Going to push as commit b65e0bb.
Since your change was applied there have been 80 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2025
@openjdk openjdk bot closed this Dec 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2025
@openjdk
Copy link

openjdk bot commented Dec 22, 2025

@sendaoYan Pushed as commit b65e0bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants