-
Notifications
You must be signed in to change notification settings - Fork 26
8369505: jhsdb jstack cannot handle continuation stub #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8369505: jhsdb jstack cannot handle continuation stub #23
Conversation
|
👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into |
|
@dbriemann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 65 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
Webrevs
|
|
/issue add JDK-8370036 |
|
@dbriemann |
|
/issue add JDK-8370201 |
|
@dbriemann |
|
/issue add JDK-8370240 |
|
@dbriemann |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this is a clean backport of the 4 issues linked in this PR. I think packing them into 1 PR makes sense because they all belong together and further backports will also need all of the 4 parts.
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/approval request jdk25u is affected by this problem. We need to backport a bundle of fixes which belong together: JDK-8369505, JDK-8370036, JDK-8370201, JDK-8370240 . |
|
@dbriemann |
|
Thanks for the review! |
|
@dbriemann |
|
/sponsor |
|
Going to push as commit a46c70d.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr @dbriemann Pushed as commit a46c70d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This pull request contains a backport of commit 16539998 from the openjdk/jdk repository.
The commit being backported was authored by Yasumasa Suenaga on 16 Oct 2025 and was reviewed by Chris Plummer and Patricio Chilano Mateo.
To make this backport work further commits needed to be backported:
JDK-8370201
JDK-8370036
Both contain fixes to the test introduced by the backported commit.
Also this backport includes another commit:
JDK-8370240
This fixes the same issue as the original commit but for the PPC platform.
A manual fix was needed because newer versions of the JDK use the name "continuation stubs" but in the older version the name was "continuationstubs".
Progress
Warning
8369505: jhsdb jstack cannot handle continuation stubIssues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/23/head:pull/23$ git checkout pull/23Update a local copy of the PR:
$ git checkout pull/23$ git pull https://git.openjdk.org/jdk25u-dev.git pull/23/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23View PR using the GUI difftool:
$ git pr show -t 23Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/23.diff
Using Webrev
Link to Webrev Comment