Skip to content

Conversation

@dbriemann
Copy link
Member

@dbriemann dbriemann commented Nov 27, 2025

This pull request contains a backport of commit 16539998 from the openjdk/jdk repository.

The commit being backported was authored by Yasumasa Suenaga on 16 Oct 2025 and was reviewed by Chris Plummer and Patricio Chilano Mateo.

To make this backport work further commits needed to be backported:
JDK-8370201
JDK-8370036
Both contain fixes to the test introduced by the backported commit.

Also this backport includes another commit:
JDK-8370240
This fixes the same issue as the original commit but for the PPC platform.

A manual fix was needed because newer versions of the JDK use the name "continuation stubs" but in the older version the name was "continuationstubs".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8370240 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369505 needs maintainer approval
  • JDK-8370201 needs maintainer approval
  • JDK-8370036 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8369505: jhsdb jstack cannot handle continuation stub

Issues

  • JDK-8369505: jhsdb jstack cannot handle continuation stub (Bug - P4 - Approved)
  • JDK-8370036: TestJhsdbJstackWithVirtualThread.java fails when run with -showversion (Bug - P4 - Approved)
  • JDK-8370201: Test serviceability/sa/TestJhsdbJstackWithVirtualThread.java fails due to VM warnings (Bug - P4 - Approved)
  • JDK-8370240: [PPC64] jhsdb jstack cannot handle continuation stub (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/23.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@dbriemann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369505: jhsdb jstack cannot handle continuation stub
8370036: TestJhsdbJstackWithVirtualThread.java fails when run with -showversion
8370201: Test serviceability/sa/TestJhsdbJstackWithVirtualThread.java fails due to VM warnings
8370240: [PPC64] jhsdb jstack cannot handle continuation stub

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1653999871c8d7b1e61b44f8525e09b2cd0bdb6b 8369505: jhsdb jstack cannot handle continuation stub Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

⚠️ @dbriemann This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2025

Webrevs

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Dec 4, 2025
@dbriemann
Copy link
Member Author

/issue add JDK-8370036

@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@dbriemann
Adding additional issue to issue list: 8370036: TestJhsdbJstackWithVirtualThread.java fails when run with -showversion.

@dbriemann
Copy link
Member Author

/issue add JDK-8370201

@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@dbriemann
Adding additional issue to issue list: 8370201: Test serviceability/sa/TestJhsdbJstackWithVirtualThread.java fails due to VM warnings.

@dbriemann
Copy link
Member Author

/issue add JDK-8370240

@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@dbriemann
Adding additional issue to issue list: 8370240: [PPC64] jhsdb jstack cannot handle continuation stub.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this is a clean backport of the 4 issues linked in this PR. I think packing them into 1 PR makes sense because they all belong together and further backports will also need all of the 4 parts.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dbriemann
Copy link
Member Author

/approval request jdk25u is affected by this problem. We need to backport a bundle of fixes which belong together: JDK-8369505, JDK-8370036, JDK-8370201, JDK-8370240 .
The backport contains all of them. All of them applied cleanly, but a small adaptation is needed which has been reviewed. Tier 1 - 4 tests have passed. Risk is low because the code only touches VMStructs, SA code and tests.

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@dbriemann
8369505: The approval request has been created successfully.
8370036: The approval request has been created successfully.
8370201: The approval request has been created successfully.
8370240: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 9, 2025
@dbriemann
Copy link
Member Author

Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@dbriemann
Your change (at version 911bede) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

Going to push as commit a46c70d.
Since your change was applied there have been 65 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2025
@openjdk openjdk bot closed this Dec 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@TheRealMDoerr @dbriemann Pushed as commit a46c70d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dbriemann dbriemann deleted the backport-dbriemann-16539998-master branch December 12, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants