-
Notifications
You must be signed in to change notification settings - Fork 147
8370197: Add missing @Override annotations in com.sun.beans package #2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8370197: Add missing @OverRide annotations in com.sun.beans package. The commit only adds compile-time safety by catching errors when you think you're overriding a method but aren't. It doesn't introduce behavioral changes. |
|
/approval request for backport of JDK-8370197: Add missing The commit only adds compile-time safety by catching errors when you think you're overriding a method but aren't. It doesn't introduce behavioral changes. |
Backporting JDK-8370197: Add missing @OverRide annotations in com.sun.beans package. PR adds missing @OverRide annotations to methods in com.sun.beans package that override superclass or interface methods. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/beans
Results are attached.
linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2498/head:pull/2498$ git checkout pull/2498Update a local copy of the PR:
$ git checkout pull/2498$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2498/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2498View PR using the GUI difftool:
$ git pr show -t 2498Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2498.diff
Using Webrev
Link to Webrev Comment