Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Dec 1, 2025

Backporting JDK-8370197: Add missing @OverRide annotations in com.sun.beans package. PR adds missing @OverRide annotations to methods in com.sun.beans package that override superclass or interface methods. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/beans

Results are attached.
linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370197 needs maintainer approval

Issue

  • JDK-8370197: Add missing @Override annotations in com.sun.beans package (Bug - P5 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2498/head:pull/2498
$ git checkout pull/2498

Update a local copy of the PR:
$ git checkout pull/2498
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2498

View PR using the GUI difftool:
$ git pr show -t 2498

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2498.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e7c7892b9f0fcee37495cce312fdd67dc800f9c9 8370197: Add missing @Override annotations in com.sun.beans package Dec 1, 2025
@openjdk
Copy link

openjdk bot commented Dec 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 1, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review December 1, 2025 19:31
@openjdk
Copy link

openjdk bot commented Dec 1, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2025

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Dec 1, 2025

/approval request for backport of JDK-8370197: Add missing @OverRide annotations in com.sun.beans package.

The commit only adds compile-time safety by catching errors when you think you're overriding a method but aren't. It doesn't introduce behavioral changes.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@rm-gh-8
8370197: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 1, 2025
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Dec 5, 2025

/approval request for backport of JDK-8370197: Add missing @Override annotations in com.sun.beans package.

The commit only adds compile-time safety by catching errors when you think you're overriding a method but aren't. It doesn't introduce behavioral changes.

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@rm-gh-8
8370197: The approval request has been updated successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant