Skip to content

Conversation

@jmtd
Copy link

@jmtd jmtd commented Nov 7, 2025

This is a trivial test only fix to backport for oracle parity.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366128 needs maintainer approval

Issue

  • JDK-8366128: jdk/jdk/nio/zipfs/TestPosix.java::testJarFile uses wrong file (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2453/head:pull/2453
$ git checkout pull/2453

Update a local copy of the PR:
$ git checkout pull/2453
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2453

View PR using the GUI difftool:
$ git pr show -t 2453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2453.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366128: jdk/jdk/nio/zipfs/TestPosix.java::testJarFile uses wrong file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 22d3a6dd34a14994c7210365a5b982c9e65f5892 8366128: jdk/jdk/nio/zipfs/TestPosix.java::testJarFile uses wrong file Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

⚠️ @jmtd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

@jmtd
Copy link
Author

jmtd commented Nov 7, 2025

Not requesting approval until 25 is resolved. 25 PR: openjdk/jdk25u#365

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2025

@jmtd This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jmtd
Copy link
Author

jmtd commented Dec 7, 2025

/approval request trivial test-only fix to backport for oracle parity. I have tested this backport.

@openjdk
Copy link

openjdk bot commented Dec 7, 2025

@jmtd
8366128: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 7, 2025
@jmtd
Copy link
Author

jmtd commented Dec 9, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

Going to push as commit 888a112.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 9, 2025
@openjdk openjdk bot closed this Dec 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2025
@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@jmtd Pushed as commit 888a112.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant