8379424: [11u] Update SSL tests using SSLEngineTemplate

[vieiro]

This fixes different security tests reported in JDK-8379424.

Tests extending SSLEngineTemplate will need to use the Utils class in /test/lib (which provides a ByteBuffer.slice(int, int) for JDK11), so the base class compiles correctly with JTReg. This is a test-only change.

All security tests pass now:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk:jdk_security                        1368  1368     0     0   
==============================
TEST SUCCESS

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8379424 needs maintainer approval

Issue

• JDK-8379424: [11u] Update SSL tests using SSLEngineTemplate (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/110/head:pull/110
$ git checkout pull/110

Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.org/jdk11u.git pull/110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 110

View PR using the GUI difftool:
$ git pr show -t 110

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/110.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8379424: [11u] Update SSL tests using SSLEngineTemplate

Reviewed-by: sgehwolf, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (0c99a93f)

[jerboaa]

Looks good.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[vieiro]

/approval request Please consider approving this fix to some security tests, that were failing after the test templates were updated with a new Utility class in the /test/lib library. All security tests pass now.

[openjdk]

@vieiro
8379424: The approval request has been created successfully.

[jerboaa]

I'll let @gnu-andrew handle approval for this one.

[gnu-andrew]

Looks good to me too. Good to see the SunEC case handled by fixing the policy.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8379424: The approval request has been approved.

[vieiro]

/integrate

[openjdk]

Going to push as commit 85846f7.

[openjdk]

@vieiro Pushed as commit 85846f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.