-
Notifications
You must be signed in to change notification settings - Fork 252
8349583: Add mechanism to disable signature schemes based on their TLS scope #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into |
|
NOTE: This one on top of #3126 , which introduces some tests required in this backport. |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backports/JDK-8349583
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@vieiro this pull request can not be integrated into git checkout backports/JDK-8349583
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
Some tests fail. Let's keep this as draft for the moment. |
|
Re-testing with Namely:
These errors are unrelated, and seem to have been introduced in this recently closed PR |
Backport of JDK-8349583 from JDK17, a first step to disable SHA-1 in TLS/DTLS 1.2 handshake signatures to comply with the Oracle JRE Cryptographic Roadmap, to be followed with JDK-8340321.
Backport is not clean, as there're significant changes from JDK17.
To ease review, three additional commits adapt the backport to JDK11, which is missing JDK-8284047 (2nd commit) and JDK-8288209 (3rd commit). Also JDK11 is missing
ByteBuffer.slice(int, int)(4th commit).Tested on Linux with
tier1tests and withrun-test-jdk_security:Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3130/head:pull/3130$ git checkout pull/3130Update a local copy of the PR:
$ git checkout pull/3130$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3130/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3130View PR using the GUI difftool:
$ git pr show -t 3130Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3130.diff
Using Webrev
Link to Webrev Comment