8379411: Use TestFramework scenarios in 837841 by krk · Pull Request #30116 · openjdk/jdk

krk · 2026-03-06T13:17:23Z

Use TestFramework scenarios to properly pass VM flags for VerifyIterativeGVN in MissedURShiftIAddILShiftIdeal.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8379411: Use TestFramework scenarios in 837841 (Enhancement - P4)

Reviewers

Quan Anh Mai (@merykitty - Reviewer)
Damon Fenacci (@dafedafe - Committer)
Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30116/head:pull/30116
$ git checkout pull/30116

Update a local copy of the PR:
$ git checkout pull/30116
$ git pull https://git.openjdk.org/jdk.git pull/30116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30116

View PR using the GUI difftool:
$ git pr show -t 30116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30116.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-03-06T13:19:14Z

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-06T13:19:29Z

@krk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379411: Use TestFramework scenarios in 837841

Reviewed-by: qamai, dfenacci, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

5e58808: 8378744: Obsolete NewSizeThreadIncrease flag
23adf6a: 8378569: Refactor test/jdk/java/net/httpclient/http3/H3ErrorHandlingTest.java to use JUnit
f1be820: 8379195: Refactor Arrays TestNG tests to use JUnit
... and 19 more: https://git.openjdk.org/jdk/compare/45fc141d29161e6957e95604a3a79dc6c0f7a830...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@merykitty, @dafedafe, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2026-03-06T13:20:24Z

@krk The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2026-03-06T13:24:49Z

Webrevs

merykitty

Looks good to me, you may not need a second reviewer for this. Let me run some quick test just to ensure it does not break in release somehow.

dafedafe

Looks good to me. Just a couple of minor questions/nits. Thanks @krk.

dafedafe · 2026-03-06T13:51:04Z

-        TestFramework.run();
+        var framework = new TestFramework();
+        framework.addScenarios(new Scenario(0));
+        framework.addScenarios(new Scenario(1, "-XX:+IgnoreUnrecognizedVMOptions", "-XX:VerifyIterativeGVN=1110"));


Would scenario 1 be the same as scenario 0 in prod builds?

Yes, is there a way to collapse them in prod?

Not sure if there is a "built-in" way but you could always check with Platform.isDebugBuild().

dafedafe · 2026-03-06T13:56:32Z

- * @run driver ${test.main.class}
- * @run driver ${test.main.class} -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
- *              -XX:VerifyIterativeGVN=1110 -Xbatch -XX:CompileCommand=compileonly,${test.main.class}::*
+ * @run main ${test.main.class}


I lost a sight of what the "convention" for the IR framework is: could it be @run driver?

I'm not so sure about the intricacies, but I think(?) run main is cheaper, because you don't need to spawn another VM, which will spawn another VM that runs the tests?

Both seem to work, is there a preferred one, what do you think @merykitty?

(didn't see your comment before posting mine)

It can definitely be (I'm just mentioning this because I remember having read it somewhere... but I'm not sure how up-to-date that is).

Update: After asking the expert, it is advisable to run IR tests with run driver. The reason is that when you pass additional flags to the test (e.g. in higher tier), with run main the flags are received by both the driver VM and the test VM, while with run driver, only the test VM receives the additional flags, which makes it more efficient, especially when those flags are stress ones.

merykitty

Test results are good.

chhagedorn

Looks good, thanks for following up on the test!

krk · 2026-03-09T11:36:38Z

/integrate

Thanks!

openjdk · 2026-03-09T11:37:33Z

@krk
Your change (at version 5c57a16) is now ready to be sponsored by a Committer.

chhagedorn · 2026-03-09T11:41:45Z

/sponsor

openjdk · 2026-03-09T11:43:39Z

Going to push as commit 2fc7bdc.
Since your change was applied there have been 22 commits pushed to the master branch:

5e58808: 8378744: Obsolete NewSizeThreadIncrease flag
23adf6a: 8378569: Refactor test/jdk/java/net/httpclient/http3/H3ErrorHandlingTest.java to use JUnit
f1be820: 8379195: Refactor Arrays TestNG tests to use JUnit
... and 19 more: https://git.openjdk.org/jdk/compare/45fc141d29161e6957e95604a3a79dc6c0f7a830...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-03-09T11:43:57Z

@chhagedorn @krk Pushed as commit 2fc7bdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8379411: Use TestFramework scenarios in 837841

e9a388f

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 6, 2026

openjdk bot added the rfr Pull request is ready for review label Mar 6, 2026

merykitty approved these changes Mar 6, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2026

dafedafe approved these changes Mar 6, 2026

View reviewed changes

address comments

d6ada87

openjdk bot removed the ready Pull request is ready to be integrated label Mar 6, 2026

use driver

5c57a16

merykitty approved these changes Mar 7, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2026

dafedafe approved these changes Mar 9, 2026

View reviewed changes

chhagedorn approved these changes Mar 9, 2026

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 9, 2026

openjdk bot added the integrated Pull request has been integrated label Mar 9, 2026

openjdk bot closed this Mar 9, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 9, 2026

Conversation

krk commented Mar 6, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 6, 2026

Uh oh!

openjdk bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

merykitty left a comment

Choose a reason for hiding this comment

Uh oh!

dafedafe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

merykitty left a comment

Choose a reason for hiding this comment

Uh oh!

chhagedorn left a comment

Choose a reason for hiding this comment

Uh oh!

krk commented Mar 9, 2026

Uh oh!

openjdk bot commented Mar 9, 2026

Uh oh!

chhagedorn commented Mar 9, 2026

Uh oh!

openjdk bot commented Mar 9, 2026

Uh oh!

openjdk bot commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

krk commented Mar 6, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Mar 6, 2026 •

edited

Loading

openjdk bot commented Mar 6, 2026 •

edited

Loading

mlbridge bot commented Mar 6, 2026 •

edited

Loading