Skip to content

8364025: MinMaxVector clipping range benchmark highestInt/Long can overflow#30115

Open
galderz wants to merge 1 commit intoopenjdk:masterfrom
galderz:topic.clipping-overflow
Open

8364025: MinMaxVector clipping range benchmark highestInt/Long can overflow#30115
galderz wants to merge 1 commit intoopenjdk:masterfrom
galderz:topic.clipping-overflow

Conversation

@galderz
Copy link
Copy Markdown
Contributor

@galderz galderz commented Mar 6, 2026

Fixed benchmark code to avoid overflowing when calculating highestInt and highestLong.

I observed this during early benchmark runs of #30070. I observed some oddities in the results with the clipping range benchmarks, and when I inspected the assembly, the values that were being used to clip didn't make sense. After fixing this the odd results went away.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8364025: MinMaxVector clipping range benchmark highestInt/Long can overflow (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30115/head:pull/30115
$ git checkout pull/30115

Update a local copy of the PR:
$ git checkout pull/30115
$ git pull https://git.openjdk.org/jdk.git pull/30115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30115

View PR using the GUI difftool:
$ git pr show -t 30115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30115.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 6, 2026

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 6, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the core-libs core-libs-dev@openjdk.org label Mar 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 6, 2026

@galderz The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 6, 2026

Webrevs

@galderz
Copy link
Copy Markdown
Contributor Author

galderz commented Mar 31, 2026

Can someone review this?

@galderz
Copy link
Copy Markdown
Contributor Author

galderz commented Mar 31, 2026

/label hotspot-compiler

@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 31, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 31, 2026

@galderz
The hotspot-compiler label was successfully added.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

@openjdk openjdk Bot removed the rfr Pull request is ready for review label Apr 16, 2026
@galderz
Copy link
Copy Markdown
Contributor Author

galderz commented Apr 17, 2026

Can anyone review this?

Copy link
Copy Markdown
Contributor

@rwestrel rwestrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@galderz
Copy link
Copy Markdown
Contributor Author

galderz commented Apr 20, 2026

/template append

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 20, 2026

@galderz The pull request template has been appended to the pull request body

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants