8364025: MinMaxVector clipping range benchmark highestInt/Long can overflow#30115
8364025: MinMaxVector clipping range benchmark highestInt/Long can overflow#30115galderz wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back galder! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
Can someone review this? |
|
/label hotspot-compiler |
|
@galderz |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
Can anyone review this? |
rwestrel
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
|
/template append |
|
@galderz The pull request template has been appended to the pull request body |
Fixed benchmark code to avoid overflowing when calculating
highestIntandhighestLong.I observed this during early benchmark runs of #30070. I observed some oddities in the results with the clipping range benchmarks, and when I inspected the assembly, the values that were being used to clip didn't make sense. After fixing this the odd results went away.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30115/head:pull/30115$ git checkout pull/30115Update a local copy of the PR:
$ git checkout pull/30115$ git pull https://git.openjdk.org/jdk.git pull/30115/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30115View PR using the GUI difftool:
$ git pr show -t 30115Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30115.diff
Using Webrev
Link to Webrev Comment