8379195: Refactor Arrays TestNG tests to use JUnit by rgiulietti · Pull Request #30111 · openjdk/jdk

rgiulietti · 2026-03-06T09:21:56Z

A migration from TestNG to JUnit

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8379195: Refactor Arrays TestNG tests to use JUnit (Sub-task - P4)

Reviewers

Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30111/head:pull/30111
$ git checkout pull/30111

Update a local copy of the PR:
$ git checkout pull/30111
$ git pull https://git.openjdk.org/jdk.git pull/30111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30111

View PR using the GUI difftool:
$ git pr show -t 30111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30111.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-03-06T09:23:48Z

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-06T09:24:47Z

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379195: Refactor Arrays TestNG tests to use JUnit

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

784dd56: 8378999: BeanContextSupport.add(Object) synchronizes on its argument
779970f: 8373626: [asan] read past end of buffer in sun.awt.image.ImagingLib.convolveBI
ea4a151: 8379156: Specify behavior of Types.asElement() on array types
... and 63 more: https://git.openjdk.org/jdk/compare/0ea7d890d98eda32912e9a8340020ee405042576...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2026-03-06T09:26:14Z

@rgiulietti The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2026-03-06T09:32:52Z

Webrevs

AlanBateman · 2026-03-06T10:50:55Z


+@TestInstance(TestInstance.Lifecycle.PER_CLASS)


Just curious why this is needed as the method source is a static method.

This test was converted by an automated tool, and this line was added by it.
I agree that it is not that useful in this case, but doesn't seem to hurt either.

Just a passing concern that some future maintainer will wonder if these tests have something subtle to require them to run with the same test case instance.

If you choose to not address it, can you file a JBS issue to remove them?

AlanBateman · 2026-03-06T10:52:50Z

I assume a deeper migration would change this to assertThrows(UnsupportedOperationException.class, itr::remove).

AlanBateman · 2026-03-06T10:54:33Z

In passing, I assume this assertFalse is redundant as it is checked in the loop.

I see it as redundant as well, but it is harmless.

AlanBateman · 2026-03-06T11:13:13Z

@@ -158,7 +160,8 @@ public void testParallelPrefixForInt(int[] data, int fromIndex, int toIndex, Int
        assertArraysEqual(parallelRangeResult, Arrays.copyOfRange(sequentialResult, fromIndex, toIndex));


With JUnit, the first parameter to assertArraysEquals is the "expected" as migration from TestNG will usually means transposing these parameters. It's really only an issue if there is failure of course, and only leads to a confusing message.

The assertArraysEqual() in this class are not JUnit methods. It's their implementations that eventually invoke the real JUnit method, with expected and actual in the conventional JUnit order.

I get that, I'm just saying its a hazard to have these wrappers follow the TestNG ordering and then transpose to use the JUnit ordering.

I see you've fixed this - thanks!

rgiulietti · 2026-03-09T09:52:12Z

/integrate

openjdk · 2026-03-09T09:53:54Z

Going to push as commit f1be820.
Since your change was applied there have been 79 commits pushed to the master branch:

996033a: 8378625: C2: Refactor MemNode::detect_access_independence to a separate method
695b833: 8377148: Remove obsolete functions Matcher::is_spillable_arg() and Matcher::interpreter_frame_pointer_reg()
7101a05: 8379404: G1: Hide ConcurrentMarkThread reference from outside ConcurrentMark
... and 76 more: https://git.openjdk.org/jdk/compare/0ea7d890d98eda32912e9a8340020ee405042576...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-03-09T09:54:06Z

@rgiulietti Pushed as commit f1be820.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8379195: Refactor Arrays TestNG tests to use JUnit

2313e39

openjdk Bot added the core-libs core-libs-dev@openjdk.org label Mar 6, 2026

openjdk Bot added the rfr Pull request is ready for review label Mar 6, 2026

AlanBateman reviewed Mar 6, 2026

View reviewed changes

rgiulietti added 2 commits March 6, 2026 15:55

Addressing reviewer comments.

868e893

Remove useless imports.

26049ef

AlanBateman approved these changes Mar 7, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Mar 7, 2026

openjdk Bot added the integrated Pull request has been integrated label Mar 9, 2026

openjdk Bot closed this Mar 9, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2026

		@@ -158,7 +160,8 @@ public void testParallelPrefixForInt(int[] data, int fromIndex, int toIndex, Int
		assertArraysEqual(parallelRangeResult, Arrays.copyOfRange(sequentialResult, fromIndex, toIndex));


		@TestInstance(TestInstance.Lifecycle.PER_CLASS)

Conversation

rgiulietti commented Mar 6, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Mar 6, 2026

Uh oh!

openjdk Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlanBateman Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlanBateman Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rgiulietti commented Mar 9, 2026

Uh oh!

openjdk Bot commented Mar 9, 2026

Uh oh!

openjdk Bot commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

rgiulietti commented Mar 6, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Mar 6, 2026 •

edited

Loading

openjdk Bot commented Mar 6, 2026 •

edited

Loading

mlbridge Bot commented Mar 6, 2026 •

edited

Loading

AlanBateman Mar 7, 2026 •

edited

Loading

AlanBateman Mar 6, 2026 •

edited

Loading