Skip to content

8379364: Shenandoah: Remove duplicate semicolons in GenShen code#30100

Closed
mrserb wants to merge 1 commit intoopenjdk:masterfrom
mrserb:JDK-8379364
Closed

8379364: Shenandoah: Remove duplicate semicolons in GenShen code#30100
mrserb wants to merge 1 commit intoopenjdk:masterfrom
mrserb:JDK-8379364

Conversation

@mrserb
Copy link
Copy Markdown
Member

@mrserb mrserb commented Mar 5, 2026

Remove duplicate semicolons (;;) in Shenandoah source files.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8379364: Shenandoah: Remove duplicate semicolons in GenShen code (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30100/head:pull/30100
$ git checkout pull/30100

Update a local copy of the PR:
$ git checkout pull/30100
$ git pull https://git.openjdk.org/jdk.git pull/30100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30100

View PR using the GUI difftool:
$ git pr show -t 30100

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30100.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 5, 2026

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 5, 2026

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379364: Shenandoah: Remove duplicate semicolons in GenShen code

Reviewed-by: wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Mar 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 5, 2026

@mrserb The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review March 6, 2026 05:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 6, 2026

Webrevs

Copy link
Copy Markdown
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 9, 2026
@mrserb
Copy link
Copy Markdown
Member Author

mrserb commented Mar 10, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 10, 2026

Going to push as commit 34fa467.
Since your change was applied there have been 65 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2026
@openjdk openjdk bot closed this Mar 10, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 10, 2026

@mrserb Pushed as commit 34fa467.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8379364 branch March 10, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants