8373110: jstack --mixed frames are broken on macOS after JDK-8371194

[YaSuenag]

JDK-8371194 (PR #28284) has broken PStack (jstack --mixed) behavior on macOS. It affects both AMD64 and AArch64. See JBS for details.

This PR fixes it to implement CFrame::toFrame.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8373110: jstack --mixed frames are broken on macOS after JDK-8371194

Issue

• JDK-8373110: jstack --mixed frames are broken on macOS after JDK-8371194 (Bug - P3)

Reviewers

• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28686/head:pull/28686
$ git checkout pull/28686

Update a local copy of the PR:
$ git checkout pull/28686
$ git pull https://git.openjdk.org/jdk.git pull/28686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28686

View PR using the GUI difftool:
$ git pr show -t 28686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28686.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373110: jstack --mixed frames are broken on macOS after JDK-8371194

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• b2daf9d: 8355522: Remove the java.locale.useOldISOCodes system property
• b99be50: 8368524: Tests are skipped and shown as passed in test/jdk/sun/security/pkcs11/Cipher/KeyWrap
• 831fe94: 8373255: Unexpected iobj and ipdb files after JDK-8370438
• ... and 30 more: https://git.openjdk.org/jdk/compare/b0f59f6021a00dc569e08810b34db21553a5b68d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a42f8f8b)
• 01: Full - Incremental (f5eeeaaf)
• 00: Full (bb892eb5)

[shipilev]

Drive-by comment:

[plummercj]

macosx-aarch64 looks fine, but it looks like there is still an issue on macosx-x64. Stack traces are empty:

"Reference Handler" #15 daemon prio=10 tid=0x00007f94c0820010 nid=29955 waiting on condition [0x000070000e080000]
   java.lang.Thread.State: RUNNABLE
   JavaThread state: _thread_blocked
0x00007ff803c3b6f6		????????

Before this change you at least got a partial stack followed by the UnsupportedPlatformException.

[YaSuenag]

@plummercj

there is still an issue on macosx-x64. Stack traces are empty

Does it happen always? or intermittently?

Before this change you at least got a partial stack followed by the UnsupportedPlatformException.

I'm not sure, but I guess jstack could not unwind frame at some point(s) due to unwind info like DWARF on Linux - jstack might not handle call frame because the symbol could not be resolved.

[plummercj]

Does it happen always? or intermittently?

Always. Every thread and with every run. All of the thread stack traces just have the one empty frame.

[YaSuenag]

@plummercj Maybe it was fixed in the latest commit on this PR. Could you check again?

[plummercj]

@plummercj Maybe it was fixed in the latest commit on this PR. Could you check again?

That seems to have fixed it. Thanks!

[plummercj]

Why is it that for aarch64 these are all "next" arguments, but for AMD64 they are not?

[YaSuenag]

I want to declare like sender(ThreadProxy th, Address sp, Address fp, Address pc) as defined in CFrame, however name of parameters (sp, fp, pc) have already declared as class members in BsdAARCH64CFrame. Thus I added next as a prefix of parameter name.

[plummercj]

Ok. Looks like that was also the case with LunuxAARCH64CFrame.