-
Notifications
You must be signed in to change notification settings - Fork 6.2k
6726690: SwingUtilities.replaceUI*Map() methods do not remove previously installed maps #28671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
60856f5
6726690: SwingUtilities.replaceUI*Map() methods do not remove previou…
prsadhuk a2fe949
Test fix
prsadhuk 63a5ac1
Test fix
prsadhuk 002b018
Redundant code remove
prsadhuk 847b6ba
Redundant code remove
prsadhuk 8502827
Fix update...ActionMap test added
prsadhuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /* | ||
| * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 6726690 | ||
| * @summary Verifies SwingUtilities.replaceUI*Map() methods remove | ||
| * previously installed maps | ||
| * @run main UIMapTest | ||
| */ | ||
|
|
||
| import java.awt.event.ActionEvent; | ||
| import java.awt.event.KeyEvent; | ||
| import javax.swing.AbstractAction; | ||
| import javax.swing.Action; | ||
| import javax.swing.ActionMap; | ||
| import javax.swing.ComponentInputMap; | ||
| import javax.swing.InputMap; | ||
| import javax.swing.JButton; | ||
| import javax.swing.JComponent; | ||
| import javax.swing.JFrame; | ||
| import javax.swing.KeyStroke; | ||
| import javax.swing.SwingUtilities; | ||
|
|
||
| public class UIMapTest { | ||
|
|
||
| public static void main(String[] args) { | ||
|
|
||
| StringBuilder str = new StringBuilder(); | ||
|
|
||
| // Create the test button | ||
| JButton button = new JButton("Test"); | ||
|
|
||
| // Create an input map that maps ENTER to the button | ||
| ComponentInputMap map = new ComponentInputMap(button); | ||
| map.put(KeyStroke.getKeyStroke("pressed ENTER"), "pressed"); | ||
| map.put(KeyStroke.getKeyStroke("released ENTER"), "released"); | ||
|
|
||
| // Add the map | ||
| SwingUtilities.replaceUIInputMap(button, JComponent.WHEN_IN_FOCUSED_WINDOW, map); | ||
|
|
||
| // Attempt to remove the map | ||
| SwingUtilities.replaceUIInputMap(button, JComponent.WHEN_IN_FOCUSED_WINDOW, null); | ||
|
|
||
| if (button.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW). | ||
| get(KeyStroke.getKeyStroke(KeyEvent.VK_ENTER, 0)) != null) { | ||
| str.append("\nSwingUtilities.replaceUIInputMap " + | ||
| "didn't remove previously installed input map"); | ||
| } | ||
|
|
||
| // Get the InputMap for the button when it has focus | ||
| InputMap inputMap = button.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW); | ||
|
|
||
| // Map the VK_ENTER key stroke to a specific action name | ||
| inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_ENTER, 0), "doEnterAction"); | ||
| Action enterAction = new AbstractAction() { | ||
| @Override | ||
| public void actionPerformed(ActionEvent e) { } | ||
| }; | ||
| button.getActionMap().put("doEnterAction", enterAction); | ||
| SwingUtilities.replaceUIActionMap(button, null); | ||
| if (button.getActionMap().size() != 0) { | ||
| str.append("\nSwingUtilities.replaceUIActionMap " + | ||
| "didn't remove previously installed action map"); | ||
| } | ||
| if (str.length() != 0) { | ||
| throw new RuntimeException(str.toString()); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the fix changes both
replaceUIInputMapandreplaceUIActionMap, onlyreplaceUIInputMapis tested.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActionMap test added