8374614: [CRaC] Remove defunct fdinfo marking

[rvansa]

When initializing fdinfos, there might be a racy native thread closing FD between enumerating FDs and readlink /proc/self/fd/XXX, causing an error and assertion to fail.

Further looking into the code it seems that the fdinfo::mark is not read since 4b0dc2d and therefore the whole check is defunct, and can be removed.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8374614: [CRaC] Remove defunct fdinfo marking (Bug - P4)

Reviewers

• Timofei Pushkin (@TimPushkin - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/284/head:pull/284
$ git checkout pull/284

Update a local copy of the PR:
$ git checkout pull/284
$ git pull https://git.openjdk.org/crac.git pull/284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 284

View PR using the GUI difftool:
$ git pr show -t 284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/284.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rvansa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374614: [CRaC] Remove defunct fdinfo marking

Reviewed-by: tpushkin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the crac branch:

• af6c844: 8373784: [CRaC] VM Option to require perfect CPU fit
• 53d1ac4: 8374491: CPUFeatures: check performance regression of AVX_Fast_Unaligned_Load
• abf0868: 8373781: [CRaC] Permit -XX:CPUFeatures on other platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (ce2ce45f)
• 00: Full (29bd3983)

[TimPushkin]

AFAIU this solves or duplicates https://bugs.openjdk.org/browse/JDK-8374791 — could you link it properly to this bug?

[rvansa]

/integrate

[openjdk]

Going to push as commit 229431d.
Since your change was applied there have been 4 commits pushed to the crac branch:

• 4b84ed3: 8371549: [CRaC] Implement C/R in Selector on non-Linux
• af6c844: 8373784: [CRaC] VM Option to require perfect CPU fit
• 53d1ac4: 8374491: CPUFeatures: check performance regression of AVX_Fast_Unaligned_Load
• ... and 1 more: https://git.openjdk.org/crac/compare/15dcf3b64e9ee3cb4ce0435c9850126e142fedf6...crac

Your commit was automatically rebased without conflicts.

[openjdk]

@rvansa Pushed as commit 229431d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.