8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo,0xbar on checkpoint by jankratochvil · Pull Request #278 · openjdk/crac

jankratochvil · 2025-12-02T13:22:18Z

Since JDK-8368929 the message:

Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xe14e1805fdfbf7,0xfcc on checkpoint.

is wrong as it does not do logical and of both CPUFeatures masks.

Yes, I should have caught it during JDK-8368929 review.

@rvansa will probably want to change the API but this is a PoC how it should work.

Progress

Change must not contain extraneous whitespace

Issue

JDK-8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo,0xbar on checkpoint (Bug - P4)

Reviewers

Radim Vansa (@rvansa - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/278/head:pull/278
$ git checkout pull/278

Update a local copy of the PR:
$ git checkout pull/278
$ git pull https://git.openjdk.org/crac.git pull/278/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 278

View PR using the GUI difftool:
$ git pr show -t 278

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/278.diff

Using Webrev

Link to Webrev Comment

…tures, try using -XX:CPUFeatures=0xfoo,0xbar on checkpoint

bridgekeeper · 2025-12-02T13:24:52Z

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-12-02T13:25:06Z

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo,0xbar on checkpoint

Reviewed-by: rvansa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 197 new commits pushed to the crac branch:

03b5564: Merge jdk:jdk-27+7
62c7e9a: 8376423: Test javax/swing/plaf/metal/MetalUtils/bug6190373.java failed: ClassCastException: class java.lang.Character cannot be cast to class javax.swing.Painter
2529e2f: 8376169: JPopupMenu.setInvoker(null) causes NPE
... and 194 more: https://git.openjdk.org/crac/compare/2f0af59e4d38d4f48bccf21f7c1515625597f749...crac

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2025-12-02T13:29:33Z

Webrevs

rvansa

A test update along with a bugfix would be welcome.

bridgekeeper · 2025-12-30T20:19:58Z

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

jankratochvil · 2026-01-04T22:13:40Z

A test update along with a bugfix would be welcome.

I see in 3260337 only test/jdk/jdk/crac/CPUFeatures/CPUFeatures.sh which has been removed by #280 . There there is a downstream testcase ZULU-82680 which already assumes this change.

jankratochvil · 2026-02-04T07:45:37Z

macros-aarch64 fail is: jdk/crac/fileDescriptors/ReopenListeningSocketChannelTest.java
macos-x64 fail is:

The macOS-13 based runner images are now retired. For more details, see https://github.com/actions/runner-images/issues/13046.

TimPushkin · 2026-02-04T07:49:25Z

@jankratochvil I think you need to update your branch from the target branch. We've recently merged the mainline so the CI issues should be solved.

jankratochvil · 2026-02-04T11:59:53Z

/integrate

openjdk · 2026-02-04T12:01:16Z

@jankratochvil
Your change (at version d27c0e7) is now ready to be sponsored by a Committer.

rvansa · 2026-02-04T12:02:07Z

/sponsor

openjdk · 2026-02-04T12:04:30Z

Going to push as commit 4a940b7.
Since your change was applied there have been 197 commits pushed to the crac branch:

03b5564: Merge jdk:jdk-27+7
62c7e9a: 8376423: Test javax/swing/plaf/metal/MetalUtils/bug6190373.java failed: ClassCastException: class java.lang.Character cannot be cast to class javax.swing.Painter
2529e2f: 8376169: JPopupMenu.setInvoker(null) causes NPE
... and 194 more: https://git.openjdk.org/crac/compare/2f0af59e4d38d4f48bccf21f7c1515625597f749...crac

Your commit was automatically rebased without conflicts.

openjdk · 2026-02-04T12:04:44Z

@rvansa @jankratochvil Pushed as commit 4a940b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8372933: [CRaC] Restore failed due to incompatible or missing CPU fea…

6bc03d2

…tures, try using -XX:CPUFeatures=0xfoo,0xbar on checkpoint

openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2025

rvansa reviewed Dec 2, 2025

View reviewed changes

Comment thread src/hotspot/share/include/crlib/crlib_image_constraints.h Outdated

Comment thread src/java.base/share/native/libcrexec/image_constraints.cpp Outdated

jankratochvil added 3 commits January 4, 2026 22:41

Merge branch 'crac' into crac-conjunction

e9064f4

conjunction->intersection

cea5510

!EQUALS->SUBSET

ccd6e15

return original prototype of is_failed(), add new get_failed_bitmap()

1e0118f

rvansa reviewed Jan 7, 2026

View reviewed changes

jankratochvil added 4 commits January 7, 2026 21:37

Fixes upon review by Radim Vansa

80b71be

Merge branch 'crac' into crac-conjunction

2823dd3

get_failed_bitmap to return stored data

69b9686

Fix non-x86 builds

90633b0

TimPushkin reviewed Feb 2, 2026

View reviewed changes

Comment thread src/java.base/share/native/libcrexec/image_constraints.cpp

Comment thread src/hotspot/share/runtime/crac_engine.cpp

rvansa reviewed Feb 2, 2026

View reviewed changes

Comment thread src/hotspot/share/include/crlib/crlib_image_constraints.h Outdated

jankratochvil added 6 commits February 2, 2026 15:45

Check for failed malloc

ca02381

Fix "try using -XX:CPUFeatures" for the 'exact' case.

8e86b98

Use current_features everywhere

b447735

get_failed_bitmap: return size_t

ca1f451

Fix the sizeof check

6da16c9

Revert the check

59a8a4b

Merge branch 'crac' into crac-conjunction

d27c0e7

rvansa approved these changes Feb 4, 2026

View reviewed changes

openjdk Bot added the sponsor Pull request is ready to be sponsored label Feb 4, 2026

openjdk Bot added the integrated Pull request has been integrated label Feb 4, 2026

openjdk Bot closed this Feb 4, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 4, 2026

Conversation

jankratochvil commented Dec 2, 2025 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Dec 2, 2025

Uh oh!

openjdk Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

rvansa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bridgekeeper Bot commented Dec 30, 2025

Uh oh!

jankratochvil commented Jan 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jankratochvil commented Feb 4, 2026

Uh oh!

TimPushkin commented Feb 4, 2026

Uh oh!

jankratochvil commented Feb 4, 2026

Uh oh!

openjdk Bot commented Feb 4, 2026

Uh oh!

rvansa commented Feb 4, 2026

Uh oh!

openjdk Bot commented Feb 4, 2026

Uh oh!

openjdk Bot commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

jankratochvil commented Dec 2, 2025 •

edited by openjdk Bot

Loading

openjdk Bot commented Dec 2, 2025 •

edited

Loading

mlbridge Bot commented Dec 2, 2025 •

edited

Loading