Skip to content

Conversation

@luiz-lvj
Copy link
Collaborator

@luiz-lvj luiz-lvj commented Jan 28, 2026

This PR removes some outdated ts files from the current release. They might be integrated later in an sdk, but are not used for v1 of the release.

Summary by CodeRabbit

  • Refactor
    • Removed prover helper abstractions and implementations previously used to enable cross-chain block hash and storage proof verification functionality. Deleted components include base abstractions for cryptographic proof handling, implementations supporting parent-to-child chain interactions, implementations supporting child-to-parent chain interactions, and specialized utilities for chain-specific proof verification and comprehensive multi-chain state validation workflows.

✏️ Tip: You can customize this high-level summary in your review settings.

@luiz-lvj luiz-lvj requested a review from frangio January 28, 2026 22:26
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

This PR removes the entire TypeScript prover helper abstraction layer, including the base class BaseProverHelper, the IProverHelper interface, two concrete implementations (ChildToParentProverHelper and ParentToChildProverHelper), and the Optimism-specific variant (OptimismChildToParentProverHelper), along with their exports from the index file.

Changes

Cohort / File(s) Summary
Base abstractions
src/ts/BaseProverHelper.ts, src/ts/IProverHelper.ts
Removed abstract base class that provided cross-chain prover interaction logic, RLP encoding utilities, and block/proof fetching methods; deleted interface defining the async prover input builder contract.
Core implementations
src/ts/ChildToParentProverHelper.ts, src/ts/ParentToChildProverHelper.ts
Removed two concrete prover helper classes that extended BaseProverHelper, implemented IProverHelper, and handled child-to-parent and parent-to-child block verification and storage proofs.
Optimism variant
src/ts/optimism/ChildToParentProverHelper.ts
Removed Optimism-specific prover helper implementation that used L1Block predeploy to fetch block hashes and construct verification proofs.
Module exports
src/ts/index.ts
Removed barrel exports for ChildToParentProverHelper, ParentToChildProverHelper, IProverHelper, and OptimismChildToParentProverHelper.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • pepebndc
  • nahimterrazas

Poem

🐰 The prover helpers hop away,
No more base classes here to stay,
RLP encodings fade from sight,
Cross-chain logic takes its flight,
Simpler paths emerge today!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of this PR, which is the removal of TypeScript files that are no longer used in the current release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@luiz-lvj luiz-lvj merged commit eee1004 into main Jan 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants