Fix for PM25 converter ClassCastException#938
Open
HubbleAstroid wants to merge 2 commits into
Open
Conversation
cdjackson
reviewed
Mar 17, 2026
| updateChannelState(new DecimalType(Math.pow(10.0, (Integer) val / 10000.0) - 1)); | ||
|
|
||
| double pm25Value = ((Number) val).doubleValue(); | ||
| updateChannelState(new DecimalType(Math.pow(10.0, pm25Value / 10000.0) - 1)); |
Contributor
There was a problem hiding this comment.
I'd suggest to make this all a single line to avoid creating the varialbe pm25Value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change to handling double value from PM25 to fix Ikea PM2.5 monitor which causes java.lang.ClassCastException.