[AI-BUILDER-22] refactor: auto-generate steps#1453
Merged
kevinkim-ogp merged 5 commits intotrunk/aifrom Mar 19, 2026
Merged
Conversation
This was referenced Mar 6, 2026
Contributor
Author
This was referenced Mar 6, 2026
kevinkim-ogp
force-pushed
the
ai-builder/combine-chat-and-readiness
branch
from
c355b2b to
f44f443
Compare
kevinkim-ogp
force-pushed
the
ai-builder/auto-generate-steps
branch
from
517dddd to
d262e9a
Compare
This was referenced Mar 6, 2026
kevinkim-ogp
changed the title
5 tasks
pregnantboy
reviewed
Mar 10, 2026
Contributor
pregnantboy
left a comment
pregnantboy
left a comment
There was a problem hiding this comment.
Currently there's an issue where the client still tries to call generateSteps when readiness check return false. not sure if it's in this PR or earlier PRs.
| const wasStreamingRef = useRef(isStreaming) | ||
| const scrollTickRef = useRef(false) | ||
|
|
||
| // Unified scroll function |
Contributor
There was a problem hiding this comment.
Consider using https://www.npmjs.com/package/use-stick-to-bottom to implement auto scroll to bottom
Contributor
Author
|
to fix: scrolling |
3 tasks
kevinkim-ogp
changed the base branch from
ai-builder/combine-chat-and-readiness
to
graphite-base/1453
kevinkim-ogp
force-pushed
the
graphite-base/1453
branch
from
f44f443 to
4bde4ac
Compare
kevinkim-ogp
force-pushed
the
ai-builder/auto-generate-steps
branch
from
d262e9a to
106e3ea
Compare
kevinkim-ogp
force-pushed
the
ai-builder/auto-generate-steps
branch
from
106e3ea to
d81a037
Compare
kevinkim-ogp
force-pushed
the
ai-builder/auto-generate-steps
branch
from
d81a037 to
6641a92
Compare
Contributor
Author
What changed?
Tests
|
This was referenced Mar 11, 2026
This was referenced Mar 18, 2026
pregnantboy
approved these changes
Mar 19, 2026
Contributor
pregnantboy
left a comment
pregnantboy
left a comment
There was a problem hiding this comment.
lgtm. just a quick question on when to use locationRef vs location
|
|
||
| navigate(`${URLS.EDITOR}/ai`, { | ||
| state: { | ||
| ...location.state, |
Contributor
There was a problem hiding this comment.
not sure when to use location.state vs locationRef.current.state
Contributor
Author
There was a problem hiding this comment.
its updated in a later PR to use locationRef.current.state so it always references the latest value. onFinish is captured by useChat at initialisation and never recreated, so location.state inside it is a stale snapshot from when the stream started. Since StepsPreview can call navigate (writing output into location.state) before onFinish fires, using the ref ensures we don't clobber that update
Contributor
Author
Merge activity
|
This was referenced Mar 19, 2026
kevinkim-ogp
added a commit
that referenced
this pull request
Mar 26, 2026
## Auto-open workflow preview and improve chat scrolling behavior ### Changes - **Auto-open preview**: Workflow preview now automatically opens when AI response completes, eliminating the need for manual "Preview steps" button - **Clear output on new input**: Reset previous workflow output when submitting new chat messages to ensure fresh step generation - **Enhanced scroll behavior**: Improved auto-scrolling logic with better handling of user messages, streaming responses, and scroll position detection - **Removed manual preview trigger**: Eliminated the "Preview steps" button and drawer close functionality since preview now opens automatically - **Optimized initial scroll**: Added proper scroll-to-bottom behavior on component mount using requestAnimationFrame for better performance ### Tests New chat - [ ] When the chat messages display the steps of the workflow, the side drawer should automatically open and display the steps in the 'Pipe builder' layout - [ ] Entering a new messages that creates a new step triggers a generation of a new preview Refresh chat window - [ ] Steps preview opens if there was a preview before refresh - [ ] Steps preview does not open if there was no preview before refresh - [ ] Auto-scrolls to the bottom of messages Cleanup - [ ] No longer see the 'Preview steps' button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-open workflow preview and improve chat scrolling behavior
Changes
Tests
New chat
Refresh chat window
Cleanup