[MRF2-15] PLU-520: Pre-bug bash fixes

[pregnantboy]

Summary

These were fixes that were discovered and fixed before bug bash

Fixes

fix: radio field not parsed properly

• was handling 'radio' instead of 'radiobutton'

to test:

• ensure that radio button shows up in mock data and submissions properly

fix: if-then step position not incrementing properly
ref: packages/backend/src/apps/formsg/triggers/new-submission/create-mrf-steps.ts

• bug where SQL query to increment steps was using app_key <> MRF_APP_KEY which is false for null
• added orWhereNull('app_key') to fix this

to test:

• When adding MRF step before if-then step, ensure that that the if-then steps still appear properly

fix: postman email step editor error

• think this was a regression where the flowId was taken from step.flow.id in AttachmentSuggestion. there was a refactor earlier in this stack where flow was removed from step since its duplicating info returned.
• fixed but retrieving flowId from EditorContext instead (please verify !)

to test:

• Email attachments still work

fix: nested step height incorrect

• CSS issue: grouped/nest steps were being squashed
• fixed by increasing height

to test:

• Grouped/nested steps dont appear squashed

fix: disabled step still appears after deleted

• Set disabled step to null on delete

to test:

• Go to reject branch and see disabled MRF step, delete the trigger, the disabled MRF step should be gone

[pregnantboy]

• [MRF2-18] PLU-520: Add LaunchDarkly Flag #1443
• [MRF2-17] PLU-520: Post-bug bash fixes (UI) #1442
• [MRF2-16] PLU-520: Post-bug bash fixes (logic) #1441
• [MRF2-15] PLU-520: Pre-bug bash fixes #1440 👈 (View in Graphite)
• [MRF2-14] PLU-520: improved UI styling #1419
• [MRF2-13] PLU-520: added attachment support #1418
• [MRF2-12] PLU-520: add integration tests #1406
• [MRF2-11] PLU-520: add backend unit tests #1405
• [MRF2-10] PLU-520: use display position instead of db position #1403
• [MRF2-9] PLU-520: Add support for FormSG v3 response processing with schema lookup #1402
• [MRF2-8] PLU-520: resolve PR comments #1396
• mrf/trunk

This stack of pull requests is managed by Graphite. Learn more about stacking.

[linear]

PLU-520 MRF: Approvals

[kevinkim-ogp]

lgtm!

[pregnantboy]

Merge activity

• Mar 6, 12:47 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Mar 6, 12:51 PM UTC: Graphite rebased this pull request as part of a merge.
• Mar 6, 12:51 PM UTC: @pregnantboy merged this pull request with Graphite.