feat: migrate frontend to pnpm by scottheng96 · Pull Request #9172 · opengovsg/FormSG

scottheng96 · 2026-03-03T08:45:57Z

Problem

Part of the work moving FormSG to monorepo structure

Closes FRM-2309

Solution

Followed steps to migrate from npm to pnpm
Updated github/ci deployment scripts
Resolved dependencies

Breaking Changes

No - this PR is backwards compatible

linear · 2026-03-03T08:46:01Z

FRM-2309 migrate frontend to pnpm

scottheng96 · 2026-03-03T08:48:27Z

            id="emails"
            isRequired
-            isInvalid={staticTagInputErrorMessage}
+            isInvalid={!!staticTagInputErrorMessage}


datadog-opengovsg · 2026-03-03T08:56:25Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 225ebe4 | Docs | Was this helpful? Give us feedback!}

kevin9foong · 2026-03-03T10:10:16Z

issue: could we explore why The CLI tried to run your build-storybook script is failing? its triggering for the downstreams as well

kevin9foong · 2026-03-04T06:26:41Z

          skip: dependabot/**
          # Only run when the react-email-preview directory has changes
-          untraced: '!(react-email-preview)/**'
+          # untraced: '!(react-email-preview)/**'


question: is this supposed to be commented out?

kevin9foong · 2026-03-04T06:29:15Z

          key: ${{ runner.OS }}-node-modules-${{ hashFiles('**/package-lock.json', '**/pnpm-lock.yaml') }}
          fail-on-cache-miss: true
-      - run: npm run lint:frontend
+      - run: pnpm lint-ci


issue: seems like lint-ci is meant to lint the backend src/ directory. is pnpm lint:frontend expected instead?

kevin9foong · 2026-03-04T06:31:56Z

+    "@chakra-ui/anatomy": "^2.3.4",
+    "@chakra-ui/checkbox": "^2.3.2",
+    "@chakra-ui/form-control": "^2.2.0",
+    "@chakra-ui/hooks": "^2.4.2",


info: btw, we can check what version we were using by searching in the old package.json. This here enforces a version bump for some of these dependencies, which we may not want to do to reduce risk this change.

for example, we were using

"node_modules/@chakra-ui/hooks": { "version": "2.2.1",

kevin9foong · 2026-03-04T06:33:05Z

    "prepare": "husky",
    "pre-commit": "lint-staged",
-    "storybook": "npm run --prefix frontend storybook",
-    "postinstall:frontend": "npm --prefix frontend install --legacy-peer-deps",


question: just for my understanding, how does pnpm resolve peer deps differently?

kevin9foong · 2026-03-04T07:23:19Z

-      - name: Install BE dependencies
-        working-directory: src
-        run: npm i
+      # - name: Install BE dependencies


issue: uncomment this

kevin9foong · 2026-03-04T07:38:23Z

+    "@chakra-ui/checkbox": "^2.3.2",
+    "@chakra-ui/form-control": "^2.2.0",
+    "@chakra-ui/hooks": "^2.2.1",
+    "@chakra-ui/layout": "^2.1.0",


should be 2.3.1

… resolved build issues

… pnpm

…eview

kevin9foong · 2026-03-04T09:15:54Z

lgtm!

* feat: migrate shared to pnpm (#9163) * feat: migrate shared to pnpm * feat: update ci to support pnpm * feat: install eslint in shared * feat: update ci scripts to install pnpm, remove pnpm caching * feat: update chromatic script with pnpm * feat: use common env for pnpm and npm and pin to specific * Merge pull request #9162 from opengovsg/feat/migrate-serverless-virus-scanner-to-pnpm feat: migrate serverless virus scanner to pnpm * feat: migrate backend to pnpm (#9164) * feat: migrate backend to pnpm * feat: use pnpm in ci scripts * feat: install missing deps and fix typing * feat: add pnpm installation to ci jobs * feat: update playwright and ci * feat: use pnpm for build * feat: create shared pnpm base * feat: use shared env version * feat: remove ebs files (#9170) * feat: remove ebextensions * feat: remove dockerrun used for ebs * feat: migrate serverless pdf lambda to pnpm (#9167) * feat: migrate pdf lambda from npm to pnpm * feat: replace ci yml scripts and build.sh to use pnpm * chore: remove --frozen-lockfile * feat: updated deploy-pdf-gen-lambda.yml to standardised pnpm steps * feat: updated ci.yml to pnpm for pdf-gen * feat: updated package.json root builds with pnpm for pdf-gen * feat: replace pnpm ci with pnpm install * feat: split build and deploy * chore: replace strategy matrix, updated README/md * feat: updated ci.yml pdf gen to use env.PNPM_VERSION * feat: updated deploy-pdf-gen-lambda to use pnpm run sam-deploy and pnpm sam-build * feat: updated quickstart.md * feat: add -p to build-dist.sh * fix: ci script typo * feat: migrate payments recon to pnpm (#9174) * feat: update payments recon documentation * chore: update staging to stg, added stg-alt3 * feat: remove npmrc * feat: update translation.md * feat: update root package json engine * feat: update playwright to build webserver using pnpm * feat: remove stale puppeteer * fix(frontend): hardcode success style extension * feat: migrate frontend to pnpm (#9172) * feat: migrated package-lock.json to pnpm-lock.yaml * feat: updated package.json to pnpm commands & added built dependencies * feat: added phantom dependencies directly into frontend/package.json, resolved build issues * feat: updated root package.json * feat: updated readme, quickstart & missed package.json * chore: remove legacy-peer-deps * feat: updated ci.yml file * feat: added install pnpm to frontend_lint & _test in ci.yml * feat: updated Dockerfile production to copy pnpm-lock.yaml: * chore: replace all pnpm run with pnpm * feat: updated Dockerfile * feat: updated chromatic.yml * chore: remove cache, updated emailpreview in chromatic.yml to install pnpm * chore: remove untraced to explicitly run react-email-preview * fix: remove BE dependency installed from chromatic.yml * feat: replace package-lock.json with pnpm-lock.yaml for react-eail-preview * feat: add microtime to built dependencies for package.json frontend * fix: addressed comments * fix: updated package versions to match package-lock.json * feat: update pnpm lock * fix: uncommented testing code * fix: email be dep working dir * fix: lint errors * feat: migrate react-email-preview to pnpm * fix: bummp react-rotuer version * fix: updated layout package.json * fix: ran pnpm install for frontend * feat: move ignore built deps to package.json * fix: frontend lint * feat: update readme * feat: update comments and readme to use pnpm --------- Co-authored-by: Kevin Foong <55353265+kevin9foong@users.noreply.github.com> Co-authored-by: Eliot Lim <eliot@open.gov.sg> --------- Co-authored-by: scottheng96 <44297674+scottheng96@users.noreply.github.com> Co-authored-by: Eliot Lim <eliot@open.gov.sg>

* feat: monorepo phase 1 - migrate npm to pnpm (#9166) * feat: migrate shared to pnpm (#9163) * feat: migrate shared to pnpm * feat: update ci to support pnpm * feat: install eslint in shared * feat: update ci scripts to install pnpm, remove pnpm caching * feat: update chromatic script with pnpm * feat: use common env for pnpm and npm and pin to specific * Merge pull request #9162 from opengovsg/feat/migrate-serverless-virus-scanner-to-pnpm feat: migrate serverless virus scanner to pnpm * feat: migrate backend to pnpm (#9164) * feat: migrate backend to pnpm * feat: use pnpm in ci scripts * feat: install missing deps and fix typing * feat: add pnpm installation to ci jobs * feat: update playwright and ci * feat: use pnpm for build * feat: create shared pnpm base * feat: use shared env version * feat: remove ebs files (#9170) * feat: remove ebextensions * feat: remove dockerrun used for ebs * feat: migrate serverless pdf lambda to pnpm (#9167) * feat: migrate pdf lambda from npm to pnpm * feat: replace ci yml scripts and build.sh to use pnpm * chore: remove --frozen-lockfile * feat: updated deploy-pdf-gen-lambda.yml to standardised pnpm steps * feat: updated ci.yml to pnpm for pdf-gen * feat: updated package.json root builds with pnpm for pdf-gen * feat: replace pnpm ci with pnpm install * feat: split build and deploy * chore: replace strategy matrix, updated README/md * feat: updated ci.yml pdf gen to use env.PNPM_VERSION * feat: updated deploy-pdf-gen-lambda to use pnpm run sam-deploy and pnpm sam-build * feat: updated quickstart.md * feat: add -p to build-dist.sh * fix: ci script typo * feat: migrate payments recon to pnpm (#9174) * feat: update payments recon documentation * chore: update staging to stg, added stg-alt3 * feat: remove npmrc * feat: update translation.md * feat: update root package json engine * feat: update playwright to build webserver using pnpm * feat: remove stale puppeteer * fix(frontend): hardcode success style extension * feat: migrate frontend to pnpm (#9172) * feat: migrated package-lock.json to pnpm-lock.yaml * feat: updated package.json to pnpm commands & added built dependencies * feat: added phantom dependencies directly into frontend/package.json, resolved build issues * feat: updated root package.json * feat: updated readme, quickstart & missed package.json * chore: remove legacy-peer-deps * feat: updated ci.yml file * feat: added install pnpm to frontend_lint & _test in ci.yml * feat: updated Dockerfile production to copy pnpm-lock.yaml: * chore: replace all pnpm run with pnpm * feat: updated Dockerfile * feat: updated chromatic.yml * chore: remove cache, updated emailpreview in chromatic.yml to install pnpm * chore: remove untraced to explicitly run react-email-preview * fix: remove BE dependency installed from chromatic.yml * feat: replace package-lock.json with pnpm-lock.yaml for react-eail-preview * feat: add microtime to built dependencies for package.json frontend * fix: addressed comments * fix: updated package versions to match package-lock.json * feat: update pnpm lock * fix: uncommented testing code * fix: email be dep working dir * fix: lint errors * feat: migrate react-email-preview to pnpm * fix: bummp react-rotuer version * fix: updated layout package.json * fix: ran pnpm install for frontend * feat: move ignore built deps to package.json * fix: frontend lint * feat: update readme * feat: update comments and readme to use pnpm --------- Co-authored-by: Kevin Foong <55353265+kevin9foong@users.noreply.github.com> Co-authored-by: Eliot Lim <eliot@open.gov.sg> --------- Co-authored-by: scottheng96 <44297674+scottheng96@users.noreply.github.com> Co-authored-by: Eliot Lim <eliot@open.gov.sg> * chore: bump version to v6.312.0 --------- Co-authored-by: scottheng96 <44297674+scottheng96@users.noreply.github.com> Co-authored-by: Eliot Lim <eliot@open.gov.sg>

scottheng96 requested a review from a team as a code owner March 3, 2026 08:45

scottheng96 changed the base branch from develop to feat/migrate-npm-to-pnpm March 3, 2026 08:46

scottheng96 commented Mar 3, 2026

View reviewed changes

kevin9foong force-pushed the feat/migrate-npm-to-pnpm branch from 21dc2ad to 65fad4b Compare March 3, 2026 10:27

kevin9foong temporarily deployed to stg-alt2 March 4, 2026 02:15 — with GitHub Actions Inactive

kevin9foong reviewed Mar 4, 2026

View reviewed changes

scottheng96 added 14 commits March 4, 2026 15:57

feat: migrated package-lock.json to pnpm-lock.yaml

e0256e9

feat: updated package.json to pnpm commands & added built dependencies

22ab03a

feat: added phantom dependencies directly into frontend/package.json,…

aabb402

… resolved build issues

feat: updated root package.json

424d11d

feat: updated readme, quickstart & missed package.json

c9b93cb

chore: remove legacy-peer-deps

0d42db3

feat: updated ci.yml file

72d0eea

feat: added install pnpm to frontend_lint & _test in ci.yml

e123e19

feat: updated Dockerfile production to copy pnpm-lock.yaml:

d72d710

chore: replace all pnpm run with pnpm

b15fc6b

feat: updated Dockerfile

bcd11fa

feat: updated chromatic.yml

d2be7ef

chore: remove cache, updated emailpreview in chromatic.yml to install…

2fcd0f8

… pnpm

chore: remove untraced to explicitly run react-email-preview

86a69ae

scottheng96 and others added 15 commits March 4, 2026 15:57

fix: remove BE dependency installed from chromatic.yml

4f8d140

feat: replace package-lock.json with pnpm-lock.yaml for react-eail-pr…

5214147

…eview

feat: add microtime to built dependencies for package.json frontend

7354576

fix: addressed comments

7c8520e

fix: updated package versions to match package-lock.json

e343f7d

feat: update pnpm lock

9f9cc36

fix: uncommented testing code

39efd0b

fix: email be dep working dir

561016e

fix: lint errors

6b2910f

feat: migrate react-email-preview to pnpm

7cb90d6

fix: bummp react-rotuer version

1d45298

fix: updated layout package.json

d21ade3

fix: ran pnpm install for frontend

3762d8f

feat: move ignore built deps to package.json

863408c

fix: frontend lint

d6b61a4

kevin9foong force-pushed the feat/migrate-frontend-to-pnpm branch from f2485ff to d6b61a4 Compare March 4, 2026 07:57

kevin9foong added 2 commits March 4, 2026 15:59

feat: update readme

9807734

feat: update comments and readme to use pnpm

225ebe4

kevin9foong approved these changes Mar 4, 2026

View reviewed changes

kevin9foong merged commit 8e65bfc into feat/migrate-npm-to-pnpm Mar 4, 2026
21 of 24 checks passed

kevin9foong deleted the feat/migrate-frontend-to-pnpm branch March 4, 2026 09:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate frontend to pnpm#9172

feat: migrate frontend to pnpm#9172
kevin9foong merged 31 commits intofeat/migrate-npm-to-pnpmfrom
feat/migrate-frontend-to-pnpm

scottheng96 commented Mar 3, 2026

Uh oh!

linear Bot commented Mar 3, 2026

Uh oh!

scottheng96 Mar 3, 2026

Uh oh!

datadog-opengovsg Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

kevin9foong commented Mar 3, 2026 •

edited

Loading

Uh oh!

kevin9foong Mar 4, 2026

Uh oh!

kevin9foong Mar 4, 2026

Uh oh!

kevin9foong Mar 4, 2026

Uh oh!

kevin9foong Mar 4, 2026

Uh oh!

kevin9foong Mar 4, 2026

Uh oh!

kevin9foong Mar 4, 2026

Uh oh!

kevin9foong Mar 4, 2026

Uh oh!

kevin9foong commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

scottheng96 commented Mar 3, 2026

Problem

Solution

Uh oh!

linear Bot commented Mar 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datadog-opengovsg Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevin9foong commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kevin9foong commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-opengovsg Bot commented Mar 3, 2026 •

edited

Loading

kevin9foong commented Mar 3, 2026 •

edited

Loading