Skip to content

Conversation

@tomkralidis
Copy link
Contributor

Addresses #162.

Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (Automated numbering of section swould be good too ;-)

@chris-little
Copy link
Contributor

@jonblower Are you happy to merge this PR163 to address Issue #162 ?

@jonblower
Copy link
Contributor

@chris-little @tomkralidis I have no objection in principle to the idea. But before we do anything, I think we'll need to sort out this repo to create a tag for the final version 1.0.0, and establish that future PRs will be targeting version 1.1 (and maintain a changelog). Also we'd need to update the schema.

Would this be a compulsory property from version 1.1 onwards? Maybe it should be optional to maintain backward compatibility? I assume it would apply to all CoverageJSON documents?

@tomkralidis
Copy link
Contributor Author

My vote would be compulsory moving forward only, unless there are other ways to do version detection?

@chris-little
Copy link
Contributor

I am happy for Mandatory for future versions, e.g. V1.1. And absence implies V1.0. @tomkralidis

@jonblower Do you think that this is not a completely backward compatible change? Isn't an unidentified JSON object or attribute or property ignored? If so, could we make this V1.0.1. I agree tagging is needed.

@chris-little chris-little added V1.1 Non-breaking change for Version 1.1 Priority 1 Highly desirable labels Jul 11, 2024
@chris-little chris-little changed the title add version conformance (#162) add version conformance (#163) Dec 3, 2024
@chris-little
Copy link
Contributor

chris-little commented Jul 15, 2025

@tomkralidis As the Main branch is no longer V1.0.0, which is in its own branch now, could you please alter your PR to make it version V1.0.1, then we can merge tomorrow.

@tomkralidis
Copy link
Contributor Author

Should we keep it to 1.0? This way, 1.0.x releases (assuming "patch" releases are based on backward compatible fixes) do not propagate URI changes.

@chris-little
Copy link
Contributor

But maybe knowing that something was patched (V1.n.x) is useful? We can discuss tomorrow.

@tomkralidis
Copy link
Contributor Author

Perhaps? Not sure. If we follow the OGC API "way", examples:

  • http://www.opengis.net/spec/ogcapi-features-1/1.0/req/core
  • http://www.opengis.net/spec/ogcapi-records-1/1.0/conf/record-core

...we have the x.y notation to account for "patch" updates. Unless we take the position that for encoding standards, patching matters more?

@tomkralidis
Copy link
Contributor Author

FYI this PR has now been updated to use version, not conformsTo, based on the discussion at the SWG meeting on 2025-07-30.

@tomkralidis
Copy link
Contributor Author

@chris-little PR comments addressed. Also updated metanorma doc metadata.

@tomkralidis tomkralidis requested a review from chris-little July 31, 2025 18:15
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tomkralidis

@chris-little chris-little merged commit 6d33001 into opengeospatial:master Jul 31, 2025
1 check passed
@tomkralidis tomkralidis deleted the issue-162 branch July 31, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority 1 Highly desirable V1.1 Non-breaking change for Version 1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants