-
Notifications
You must be signed in to change notification settings - Fork 8
add version conformance (#163) #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chris-little
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. (Automated numbering of section swould be good too ;-)
|
@jonblower Are you happy to merge this PR163 to address Issue #162 ? |
|
@chris-little @tomkralidis I have no objection in principle to the idea. But before we do anything, I think we'll need to sort out this repo to create a tag for the final version 1.0.0, and establish that future PRs will be targeting version 1.1 (and maintain a changelog). Also we'd need to update the schema. Would this be a compulsory property from version 1.1 onwards? Maybe it should be optional to maintain backward compatibility? I assume it would apply to all CoverageJSON documents? |
|
My vote would be compulsory moving forward only, unless there are other ways to do version detection? |
|
I am happy for Mandatory for future versions, e.g. V1.1. And absence implies V1.0. @tomkralidis @jonblower Do you think that this is not a completely backward compatible change? Isn't an unidentified JSON object or attribute or property ignored? If so, could we make this V1.0.1. I agree tagging is needed. |
|
@tomkralidis As the Main branch is no longer V1.0.0, which is in its own branch now, could you please alter your PR to make it version V1.0.1, then we can merge tomorrow. |
|
Should we keep it to |
|
But maybe knowing that something was patched (V1.n.x) is useful? We can discuss tomorrow. |
|
Perhaps? Not sure. If we follow the OGC API "way", examples:
...we have the |
|
FYI this PR has now been updated to use |
|
@chris-little PR comments addressed. Also updated metanorma doc metadata. |
chris-little
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tomkralidis
Addresses #162.