🐛(validation) replace TypeErrors with ValueErrors#632
Merged
Conversation
`TypeError`s are not supported as validation errors by Pydantic: it won't encapsulate them in a ValidationError. We replace them with `ValueError`s, which work as expected. see: https://pydantic.dev/docs/validation/latest/concepts/validators/ \#raising-validation-errors
…_error Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # CHANGELOG.md
MYilFun00
approved these changes
Jul 6, 2026
MYilFun00
left a comment
MYilFun00
left a comment
Contributor
There was a problem hiding this comment.
Approving. TypeErrors raised inside validators are not caught by Pydantic
as validation errors, so they were never wrapped in a ValidationError —
replacing them with ValueErrors is the correct fix and makes the models
raise as expected.
Reviewed the change scope: backends/lrs/base.py, models/xapi/base/common.py
and the two updated test files. Validated locally on top of the latest main
(branch rebased/merged, CHANGELOG conflict resolved): the xapi validation
suite passes (124 passed) and the full CI is green.
Thanks @piptouque!
MYilFun00
added a commit
to piptouque/ralph
that referenced
this pull request
Jul 6, 2026
Reconcile with main (openfun#632, openfun#634, openfun#635) and resolve CHANGELOG conflict. Co-authored-by: Cursor <cursoragent@cursor.com>
MYilFun00
added a commit
to piptouque/ralph
that referenced
this pull request
Jul 6, 2026
Reconcile with main (openfun#632, openfun#634, openfun#635) and resolve CHANGELOG conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
[
TypeErrors are not supported as validation errors by Pydantic](https://pydantic.dev/docs/validation/latest/concepts/validators/ #raising-validation-errors).So Pydantic won't encapsulate them in a
ValidationError.Proposal
We replace them with
ValueErrors, which work as expected.TypeErrors withValueErrors in Pydantic modelsCHANGELOG.md