🐛(models) fix groups' optional member field defaulting to null#630
Merged
Conversation
Without this fix, the mbox, mbox_sha1sum etc. kinds of groups still expect a member.
piptouque
force-pushed
the
fix_group_optional_member
branch
from
af72d15 to
f58fbd6
Compare
Reconcile with main (openfun#632, openfun#634, openfun#635) and resolve CHANGELOG conflict.
MYilFun00
force-pushed
the
fix_group_optional_member
branch
from
2739f19 to
e811f6f
Compare
MYilFun00
approved these changes
Jul 6, 2026
MYilFun00
left a comment
MYilFun00
left a comment
Contributor
There was a problem hiding this comment.
🐛(models) fix groups' optional member field defaulting to null (#630)
Add = None default on BaseXapiIdentifiedGroup.member so Pydantic v2
treats the field as truly optional per the xAPI spec. Without it, valid
Identified Groups without member were rejected with a 422.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
memberfield is optional in an Identified GroupWithout this fix, the mbox, mbox_sha1sum etc. kinds of groups still expect a member.
Proposal
The
memberfield ofBaseXxapiIdentifiedGroupdid not have a default value even though it isOptional.This commit sets it to
None, which is in line with other optional fields.CHANGELOG.md