Cache timeline instance fields by class name#41
Open
Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Open
Cache timeline instance fields by class name#41Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Conversation
Cache Type.getInstanceFields() results per class name in SymbolTimeline and AnimateTimeline to avoid repeated reflection during clip attachment/update. This reduces CPU and GC pressure when many symbols are instantiated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This caches
Type.getInstanceFields()results per class name in timeline code.Motivation
Timeline attachment/update can hit the same reflection path many times when many symbols of the same class are instantiated.
Changes
AnimateTimelineSymbolTimelineImpact
This reduces repeated reflection work and should lower CPU and GC pressure in symbol-heavy scenes.