Skip to content

Use a consistent instance key in AnimateLibrary to prevent leaked references. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NipponSunrise wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use a consistent instance key in AnimateLibrary to prevent leaked references. #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/swf/exporters/animate/AnimateLibrary.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,12 @@ import openfl.filters.GlowFilter;
private var rootPath:String;
private var symbols:Map<Int, AnimateSymbol>;
private var symbolsByClassName:Map<String, AnimateSymbol>;
private var uuid:String;

public function new(id:String, uuid:String = null)
{
super();

this.id = id;
this.uuid = uuid;

instanceID = uuid != null ? uuid : id;

Expand All @@ -86,7 +84,7 @@ import openfl.filters.GlowFilter;
rootPath = "";
#end

instances.set(uuid, this);
instances.set(instanceID, this);

// Hack to include filter classes, macro.include is not working properly

Expand Down Expand Up @@ -446,7 +444,7 @@ import openfl.filters.GlowFilter;
#if lime
public override function unload():Void
{
instances.remove(uuid);
instances.remove(instanceID);
if (symbols == null) return;
// if (swf == null) return;

Expand Down